Issue 9903019: Reset function info counters after context disposal in incremental marking step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9903019: Reset function info counters after context disposal in incremental marking step. (Closed)

Created:
8 years, 8 months ago by ulan

Modified:
8 years, 8 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reset function info counters after context disposal in incremental marking step. R=mstarzinger@chromium.org BUG=117767, V8:1902 TEST=test/cctest/test-heap/ResetSharedFunctionInfoCountersDuringIncrementalMarking Committed: https://code.google.com/p/v8/source/detail?r=11222

Patch Set 1 : Comments #

Patch Set 2 : Rebased #

Patch Set 3 : Fix compile error #

Patch Set 4 : Add SharedFunctionInfoIterateBody #

Total comments: 2

Patch Set 5 : Address comments #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -3 lines)			Patch
M	src/incremental-marking.cc	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1 2 3 4	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	1 2 3 4	3 chunks	+10 lines, -3 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 2	1 chunk	+87 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 8 months ago (2012-04-03 16:38:13 UTC) #3

LGTM (with two nits).

https://chromiumcodereview.appspot.com/9903019/diff/10001/src/incremental-mar...
File src/incremental-marking.cc (right):

https://chromiumcodereview.appspot.com/9903019/diff/10001/src/incremental-mar...
src/incremental-marking.cc:212: ObjectVisitor::VisitSharedFunctionInfo(shared);
You don't need that call anymore.

https://chromiumcodereview.appspot.com/9903019/diff/10001/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/9903019/diff/10001/src/objects.cc#newc...
src/objects.cc:7994: void
ObjectVisitor::VisitSharedFunctionInfo(SharedFunctionInfo* shared) {
You could move that to the header file.

Expand Messages | Collapse Messages