Issue 9903015: Fix offset computation for EmitProfilingCounterReset in x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9903015: Fix offset computation for EmitProfilingCounterReset in x64. (Closed)

Created:
8 years, 8 months ago by ulan

Modified:
8 years, 8 months ago

Reviewers:
Erik Corry, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix offset computation for EmitProfilingCounterReset in x64. R=jkummerow@chromium.org BUG=v8:2039 Committed: https://code.google.com/p/v8/source/detail?r=11186

Patch Set 2 : Address comments #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -18 lines)			Patch
	M	src/x64/deoptimizer-x64.cc	View	1	3 chunks	+2 lines, -16 lines	0 comments	Download
	M	src/x64/full-codegen-x64.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nits. Thanks for fixing this! https://chromiumcodereview.appspot.com/9903015/diff/1/src/x64/deoptimizer-x64.cc File src/x64/deoptimizer-x64.cc (right): https://chromiumcodereview.appspot.com/9903015/diff/1/src/x64/deoptimizer-x64.cc#newcode148 src/x64/deoptimizer-x64.cc:148: ASSERT_EQ(kJnsOffset, *(call_target_address ...

8 years, 8 months ago (2012-03-29 13:51:49 UTC) #2

Erik Corry

8 years, 8 months ago (2012-03-29 19:36:00 UTC) #3

https://chromiumcodereview.appspot.com/9903015/diff/1/src/x64/deoptimizer-x64.cc
File src/x64/deoptimizer-x64.cc (right):

https://chromiumcodereview.appspot.com/9903015/diff/1/src/x64/deoptimizer-x64...
src/x64/deoptimizer-x64.cc:148: ASSERT_EQ(kJnsOffset,         
*(call_target_address - 2));
On 2012/03/29 13:51:49, Jakob wrote:
> nit: let's keep the second arguments of all these ASSERT_EQs aligned (can also
> move them all to the left now that the longest line is gone).

We should align all of them or none of them.  Until now we have not normally
done this sort of aligning in V8 (I am sure there are exceptions to this).

Expand Messages | Collapse Messages

Issue 9903015: Fix offset computation for EmitProfilingCounterReset in x64. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments #

Messages