Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 9903014: Using WeakPtr for requests to MediaStreamDispatcher. (Closed)

Created:
8 years, 8 months ago by Henrik Grunell
Modified:
8 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Using WeakPtr for requests to MediaStreamDispatcher. This is to ensure no dangling pointers to MediaStreamImpl (and other requesters). It's one of several fixes for the bug. No actual crash or issue has been reported that this CL fixes; it's for removing potential issues. BUG=112408 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131330

Patch Set 1 #

Patch Set 2 : Unit test fix. #

Patch Set 3 : Adding mocks that were missing in last patch. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -63 lines) Patch
M content/renderer/media/media_stream_dispatcher.h View 2 chunks +12 lines, -10 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.cc View 12 chunks +43 lines, -29 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher_unittest.cc View 1 6 chunks +14 lines, -13 lines 0 comments Download
M content/renderer/media/media_stream_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.h View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Henrik Grunell
8 years, 8 months ago (2012-03-29 11:38:48 UTC) #1
tommi (sloooow) - chröme
lgtm
8 years, 8 months ago (2012-03-29 21:24:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/9903014/1
8 years, 8 months ago (2012-03-29 21:25:15 UTC) #3
commit-bot: I haz the power
Presubmit check for 9903014-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-03-29 21:25:20 UTC) #4
tommi (sloooow) - chröme
Hey John - do you mind taking a look? We need a stamp for the ...
8 years, 8 months ago (2012-03-29 21:27:49 UTC) #5
jam
lgtm
8 years, 8 months ago (2012-03-29 23:11:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/9903014/1
8 years, 8 months ago (2012-03-30 05:42:04 UTC) #7
commit-bot: I haz the power
Try job failure for 9903014-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-03-30 06:00:49 UTC) #8
Henrik Grunell
Tommi, I had forgot to update the unit test. Please review that one file in ...
8 years, 8 months ago (2012-04-02 08:19:27 UTC) #9
tommi (sloooow) - chröme
lgtm
8 years, 8 months ago (2012-04-03 09:34:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/9903014/12002
8 years, 8 months ago (2012-04-03 09:34:32 UTC) #11
commit-bot: I haz the power
Try job failure for 9903014-12002 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-03 09:53:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/9903014/26001
8 years, 8 months ago (2012-04-08 19:28:56 UTC) #13
commit-bot: I haz the power
8 years, 8 months ago (2012-04-08 22:57:28 UTC) #14
Try job failure for 9903014-26001 (retry) (retry) on win_rel for step
"ipc_tests" (clobber build).
It's a second try, previously, step "ipc_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698