Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: chrome/browser/ui/webui/fallback_icon_source.h

Issue 988863002: [Fallback icons] Change "explicit flow" interface so color hex strings don't use "#". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/common/favicon/fallback_icon_url_parser.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_FALLBACK_ICON_SOURCE_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_FALLBACK_ICON_SOURCE_H_
6 #define CHROME_BROWSER_UI_WEBUI_FALLBACK_ICON_SOURCE_H_ 6 #define CHROME_BROWSER_UI_WEBUI_FALLBACK_ICON_SOURCE_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "components/favicon_base/fallback_icon_service.h" 9 #include "components/favicon_base/fallback_icon_service.h"
10 #include "content/public/browser/url_data_source.h" 10 #include "content/public/browser/url_data_source.h"
11 11
12 // FallbackIconSource services explicit chrome:// requests for fallback icons. 12 // FallbackIconSource services explicit chrome:// requests for fallback icons.
13 // 13 //
14 // Format: 14 // Format:
15 // chrome://fallback-icon/size,bc,tc,fsr,r/url 15 // chrome://fallback-icon/size,bc,tc,fsr,r/url
16 // All of the parameters except for the url are optional. However, the order of 16 // All of the parameters except for the url are optional. However, the order of
17 // the parameters is not interchangeable, and all "," must be in place. 17 // the parameters is not interchangeable, and all "," must be in place.
18 // 18 //
19 // Parameter: 19 // Parameter:
20 // 'size' 20 // 'size'
21 // Positive integer to specify the fallback icon's size in pixels. 21 // Positive integer to specify the fallback icon's size in pixels.
22 // 'bc' 22 // 'bc'
23 // Fallback icon's background color, as named CSS color, or #RGB / #RRGGBB / 23 // Fallback icon's background color, as named CSS color, or RGB / ARGB /
24 // #AARRGGBB hex formats. 24 // RRGGBB / AARRGGBB hex formats (no leading "#").
25 // 'tc' 25 // 'tc'
26 // Fallback icon text color, as named CSS color, or #RGB / #RRGGBB / 26 // Fallback icon text color, as named CSS color, or RGB / ARGB / RRGGBB /
27 // #AARRGGBB hex formats. 27 // AARRGGBB hex formats (no leading "#").
28 // 'fsr' 28 // 'fsr'
29 // Number in [0.0, 1.0] to specify the fallback icon's font size (pixels) 29 // Number in [0.0, 1.0] to specify the fallback icon's font size (pixels)
30 // as a ratio to the icon's size. 30 // as a ratio to the icon's size.
31 // 'r' 31 // 'r'
32 // Number in [0.0, 1.0] to specify the fallback icon's roundness. 32 // Number in [0.0, 1.0] to specify the fallback icon's roundness.
33 // 0.0 specifies a square icon; 1.0 specifies a circle icon; intermediate 33 // 0.0 specifies a square icon; 1.0 specifies a circle icon; intermediate
34 // values specify a rounded square icon. 34 // values specify a rounded square icon.
35 // 'url' 35 // 'url'
36 // String to specify the page URL of the fallback icon. 36 // String to specify the page URL of the fallback icon.
37 // 37 //
(...skipping 22 matching lines...) Expand all
60 // Sends the default fallback icon. 60 // Sends the default fallback icon.
61 void SendDefaultResponse( 61 void SendDefaultResponse(
62 const content::URLDataSource::GotDataCallback& callback); 62 const content::URLDataSource::GotDataCallback& callback);
63 63
64 scoped_ptr<favicon_base::FallbackIconService> fallback_icon_service_; 64 scoped_ptr<favicon_base::FallbackIconService> fallback_icon_service_;
65 65
66 DISALLOW_COPY_AND_ASSIGN(FallbackIconSource); 66 DISALLOW_COPY_AND_ASSIGN(FallbackIconSource);
67 }; 67 };
68 68
69 #endif // CHROME_BROWSER_UI_WEBUI_FALLBACK_ICON_SOURCE_H_ 69 #endif // CHROME_BROWSER_UI_WEBUI_FALLBACK_ICON_SOURCE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/common/favicon/fallback_icon_url_parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698