Issue 9884001: Added screen options menu.

Issue 9884001: Added screen options menu. (Closed)

Created:
8 years, 9 months ago by Jamie

Modified:
8 years, 9 months ago

Reviewers:
simonmorris

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added screen options menu. BUG=119092 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129535

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use Document.prototype instead of document to declare the webkitIsFullScreen property. #

Total comments: 10

Patch Set 3 : Moved 'close' event handler target and phase. #

Patch Set 4 : Reviewer feedback. #

Total comments: 2

Patch Set 5 : Simplified onShow callback. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+260 lines, -23 lines)			Patch
M	remoting/remoting.gyp	View		2 chunks	+3 lines, -0 lines	0 comments	Download
A	remoting/resources/tick.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	remoting/webapp/_locales/en/messages.json	View	1 2 3	4 chunks	+16 lines, -4 lines	0 comments	Download
M	remoting/webapp/client_session.js	View	1 2 3 4	4 chunks	+50 lines, -6 lines	0 comments	Download
M	remoting/webapp/event_handlers.js	View		1 chunk	+0 lines, -1 line	0 comments	Download
A	remoting/webapp/jscompiler_hacks.js	View	1 2 3	1 chunk	+19 lines, -0 lines	0 comments	Download
M	remoting/webapp/main.css	View		2 chunks	+1 line, -8 lines	0 comments	Download
M	remoting/webapp/main.html	View		3 chunks	+14 lines, -3 lines	0 comments	Download
A	remoting/webapp/menu_button.css	View		1 chunk	+66 lines, -0 lines	0 comments	Download
A	remoting/webapp/menu_button.js	View	1 2 3	1 chunk	+91 lines, -0 lines	0 comments	Download
M	remoting/webapp/remoting.js	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	remoting/webapp/toolbar.css	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Jamie

ptal https://chromiumcodereview.appspot.com/9884001/diff/1/remoting/webapp/main.css File remoting/webapp/main.css (right): https://chromiumcodereview.appspot.com/9884001/diff/1/remoting/webapp/main.css#newcode201 remoting/webapp/main.css:201: button:active:not([disabled]) { Only tangentially related to this CL. ...

8 years, 9 months ago (2012-03-28 22:04:53 UTC) #1

Jamie

Because our plugin is floating, the <body> tag only covers the tool-bar, reducing the area ...

8 years, 9 months ago (2012-03-28 22:48:13 UTC) #2

simonmorris

http://codereview.chromium.org/9884001/diff/4001/remoting/webapp/_locales/en/messages.json File remoting/webapp/_locales/en/messages.json (right): http://codereview.chromium.org/9884001/diff/4001/remoting/webapp/_locales/en/messages.json#newcode295 remoting/webapp/_locales/en/messages.json:295: "description": "Menu option for disabling scale-to-fit. When clicked, the ...

8 years, 9 months ago (2012-03-28 22:55:02 UTC) #3

Jamie

https://chromiumcodereview.appspot.com/9884001/diff/4001/remoting/webapp/_locales/en/messages.json File remoting/webapp/_locales/en/messages.json (right): https://chromiumcodereview.appspot.com/9884001/diff/4001/remoting/webapp/_locales/en/messages.json#newcode295 remoting/webapp/_locales/en/messages.json:295: "description": "Menu option for disabling scale-to-fit. When clicked, the ...

8 years, 9 months ago (2012-03-28 23:47:46 UTC) #4

simonmorris

lgtm http://codereview.chromium.org/9884001/diff/16001/remoting/webapp/client_session.js File remoting/webapp/client_session.js (right): http://codereview.chromium.org/9884001/diff/16001/remoting/webapp/client_session.js#newcode582 remoting/webapp/client_session.js:582: remoting.MenuButton.select(this.shrinkToFit_, true); I was thinking of remoting.MenuButton.select(this.shrinkToFit_, this.scaleToFit); ...

8 years, 9 months ago (2012-03-29 00:00:43 UTC) #5

Jamie

8 years, 9 months ago (2012-03-29 00:06:53 UTC) #6

FYI.

https://chromiumcodereview.appspot.com/9884001/diff/16001/remoting/webapp/cli...
File remoting/webapp/client_session.js (right):

https://chromiumcodereview.appspot.com/9884001/diff/16001/remoting/webapp/cli...
remoting/webapp/client_session.js:582:
remoting.MenuButton.select(this.shrinkToFit_, true);
On 2012/03/29 00:00:43, simonmorris wrote:
> I was thinking of
> 
> remoting.MenuButton.select(this.shrinkToFit_, this.scaleToFit);
> remoting.MenuButton.select(this.originalSize_, !this.scaleToFit);
> 
> But that could be a separate CL.

No, you're right. That's much nicer. Done.

Expand Messages | Collapse Messages