Chromium Code Reviews Chromium Code Reviews
Issue 987883002:
Upstream Layout.java and associated files (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="UTF-8"?> | 1 <?xml version="1.0" encoding="UTF-8"?> |
| 2 <!-- | 2 <!-- |
| 3 Copyright (c) 2012 The Chromium Authors. All rights reserved. | 3 Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 4 Use of this source code is governed by a BSD-style license that can be | 4 Use of this source code is governed by a BSD-style license that can be |
| 5 found in the LICENSE file. | 5 found in the LICENSE file. |
| 6 --> | 6 --> |
| 7 | 7 |
| 8 <!-- | 8 <!-- |
| 9 Documentation: http://findbugs.sourceforge.net/manual/filter.html | 9 Documentation: http://findbugs.sourceforge.net/manual/filter.html |
| 10 In particular, ~ at the start of a string means it's a regex. | 10 In particular, ~ at the start of a string means it's a regex. |
| 11 --> | 11 --> |
| 12 <FindBugsFilter> | 12 <FindBugsFilter> |
| 13 <!-- Skip the generated resource classes (including nested classes). --> | 13 <!-- Skip the generated resource classes (including nested classes). --> |
| 14 <Match> | 14 <Match> |
| 15 <Class name="~org\.chromium\..*\.R(\$\w+)?" /> | 15 <Class name="~org\.chromium\..*\.R(\$\w+)?" /> |
| 16 </Match> | 16 </Match> |
| 17 <Match> | 17 <Match> |
| 18 <Class name="~org\.chromium\..*\.Manifest(\$\w+)?" /> | 18 <Class name="~org\.chromium\..*\.Manifest(\$\w+)?" /> |
| 19 </Match> | 19 </Match> |
| 20 <!-- Ignore "reliance on default String encoding" warnings, as we're not multi -platform --> | 20 <!-- Ignore "reliance on default String encoding" warnings, as we're not multi -platform --> |
| 21 | 21 |
| 22 <Bug pattern="DM_DEFAULT_ENCODING" /> | 22 <Bug pattern="DM_DEFAULT_ENCODING" /> |
| 23 <!-- Ignore may expose internal representation by returning Layout.mLayoutTabs . | |
| 24 This expose an array and a copy here would be too expensive. --> | |
| 25 <Match> | |
| 26 <Class name="org.chromium.chrome.browser.compositor.layouts.Layout" /> | |
|
Yaron
2015/03/09 21:32:55
Can you just use SuppressFBWarnings instead?
David Trainor- moved to gerrit
2015/03/09 22:07:44
Oh forgot we have that. Thanks :).
| |
| 27 <Method name="getLayoutTabsToRender" /> | |
| 28 <Bug pattern="EI_EXPOSE_REP" /> | |
| 29 </Match> | |
| 23 <!-- Ignore bugs that are often false-positives in test code --> | 30 <!-- Ignore bugs that are often false-positives in test code --> |
| 24 <Match> | 31 <Match> |
| 25 <Class name="~org\.chromium\..*Test(\$\w+)?" /> | 32 <Class name="~org\.chromium\..*Test(\$\w+)?" /> |
| 26 <Or> | 33 <Or> |
| 27 <Bug code="DLS,UrF" /> | 34 <Bug code="DLS,UrF" /> |
| 28 <Bug pattern="DM_GC" /> | 35 <Bug pattern="DM_GC" /> |
| 29 </Or> | 36 </Or> |
| 30 </Match> | 37 </Match> |
| 31 <!-- | 38 <!-- |
| 32 crbug.com/449101 | 39 crbug.com/449101 |
| 33 Ignore findbugs plugin test cases. | 40 Ignore findbugs plugin test cases. |
| 34 --> | 41 --> |
| 35 <Match> | 42 <Match> |
| 36 <Or> | 43 <Or> |
| 37 <Class name="~org\.chromium\.tools\.findbugs\.plugin\.SimpleSynchronizedMe thod" /> | 44 <Class name="~org\.chromium\.tools\.findbugs\.plugin\.SimpleSynchronizedMe thod" /> |
| 38 <Class name="~org\.chromium\.tools\.findbugs\.plugin\.SimpleSynchronizedSt aticMethod" /> | 45 <Class name="~org\.chromium\.tools\.findbugs\.plugin\.SimpleSynchronizedSt aticMethod" /> |
| 39 <Class name="~org\.chromium\.tools\.findbugs\.plugin\.SimpleSynchronizedTh is" /> | 46 <Class name="~org\.chromium\.tools\.findbugs\.plugin\.SimpleSynchronizedTh is" /> |
| 40 </Or> | 47 </Or> |
| 41 </Match> | 48 </Match> |
| 42 </FindBugsFilter> | 49 </FindBugsFilter> |
| OLD | NEW |
