lib/compiler/implementation/ssa/codegen.dart - Issue 9878001: Fix a bug where a block would be visited twice: by a non-dominating loop, and by its dominator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 9878001: Fix a bug where a block would be visited twice: by a non-dominating loop, and by its dominator. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/ssa/codegen.dart

===================================================================

--- lib/compiler/implementation/ssa/codegen.dart (revision 5927)

+++ lib/compiler/implementation/ssa/codegen.dart (working copy)

@@ -849,6 +849,11 @@

visitBasicBlock(dominated[0]);

}

endLoop(node.block);

+ // If the branch does not dominate the code after the loop, the

+ // dominator will visit it.

+ if (branchBlock.successors[1].dominator !== branchBlock) return;

visitBasicBlock(branchBlock.successors[1]);

// With labeled breaks we can have more dominated blocks.

if (dominated.length >= 3) {

« no previous file with comments | « no previous file | tests/co19/co19-leg.status » ('j') | no next file with comments »