Issue 9877018: Lazy background page branding: "Transient Background Page". Rename

Issue 9877018: Lazy background page branding: "Transient Background Page". Rename (Closed)

Created:
8 years, 9 months ago by Matt Perry

Modified:
8 years, 9 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Lazy background page branding: "Transient Background Page". Rename public-facing API stuff. BUG=no TEST=no Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129520

Patch Set 4 : .. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -34 lines)			Patch
M	chrome/browser/extensions/extension_service.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	1 2 3	3 chunks	+9 lines, -7 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 2	3 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/common/extensions/extension_manifest_constants.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/extension_manifest_constants.cc	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/broadcast_event/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/browser_action_create_tab/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/browser_action_with_callback/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/incognito_split/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/messaging/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/on_installed/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/wait_for_request/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/lazy_background_page/wait_for_view/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

http://codereview.chromium.org/9877018/diff/1/chrome/common/extensions/extension.cc File chrome/common/extensions/extension.cc (right): http://codereview.chromium.org/9877018/diff/1/chrome/common/extensions/extension.cc#newcode1812 chrome/common/extensions/extension.cc:1812: *error = ASCIIToUTF16(errors::kInvalidBackgroundPersistent); I think you want to change ...

8 years, 9 months ago (2012-03-28 21:46:51 UTC) #2

Matt Perry

8 years, 9 months ago (2012-03-28 21:53:14 UTC) #3

Yoyo Zhou

8 years, 9 months ago (2012-03-28 21:55:27 UTC) #4

LGTM

http://codereview.chromium.org/9877018/diff/8001/chrome/common/extensions/ext...
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/9877018/diff/8001/chrome/common/extensions/ext...
chrome/common/extensions/extension.cc:1805: Value* background_persistent = NULL;
Might want to rename this too.

Expand Messages | Collapse Messages