Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 9877010: Decreases the number of pixels needed to trigger a snap from 200 to (Closed)

Created:
8 years, 9 months ago by sky
Modified:
8 years, 9 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Decreases the number of pixels needed to trigger a snap from 200 to 100. BUG=120686 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129473

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/wm/workspace/snap_sizer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
8 years, 9 months ago (2012-03-28 17:28:23 UTC) #1
Ben Goodger (Google)
8 years, 9 months ago (2012-03-28 17:38:18 UTC) #2
LGTM

On Wed, Mar 28, 2012 at 10:28 AM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Decreases the number of pixels needed to trigger a snap from 200 to
> 100.
>
> BUG=120686
> TEST=none
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/9877010/<http://codereview.chromium.org/9877...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ash/wm/workspace/snap_sizer.cc
>
>
> Index: ash/wm/workspace/snap_sizer.cc
> diff --git a/ash/wm/workspace/snap_sizer.**cc
> b/ash/wm/workspace/snap_sizer.**cc
> index 8ee3e1f3fcdad918218454bcba1f66**28be59f404..**
> d81e722e0bcc93bcfee923e5218f1a**f7c7a48abb 100644
> --- a/ash/wm/workspace/snap_sizer.**cc
> +++ b/ash/wm/workspace/snap_sizer.**cc
> @@ -28,7 +28,7 @@ const float kPercents[] = { .5f, 2.0f / 3.0f, .8f };
>  //   |kMovesBeforeAdjust| times.
>  const int kDelayBeforeIncreaseMS = 500;
>  const int kMovesBeforeAdjust = 50;
> -const int kPixelsBeforeAdjust = 200;
> +const int kPixelsBeforeAdjust = 100;
>
>  }  // namespace
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698