Issue 9877009: Two tweaks to avoid invoking ShelfLayoutManager::LayoutShelf unless we

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9877009: Two tweaks to avoid invoking ShelfLayoutManager::LayoutShelf unless we (Closed)

Created:
8 years, 9 months ago by sky

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Two tweaks to avoid invoking ShelfLayoutManager::LayoutShelf unless we need to. The reason we should only invoke LayoutShelf is that it'll cancel any animations. Here's the two problematic scenarios I noticed: . ImageView::SetImage invoked PreferredSizeChanged even if it didn't. PreferredSizeChanged eventually makes it way to LayoutShelf, so we should only invoke this if the preferred size actually changed. . StatusAreaLayoutManager::SetChildBounds need not do anything if the size matches. BUG=120679 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129480

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -4 lines)			Patch
	M	ash/wm/status_area_layout_manager.cc	View		2 chunks	+17 lines, -3 lines	0 comments	Download
	M	ui/views/controls/image_view.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages