Issue 9875028: Reverting due to memory (Valgrind) errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9875028: Reverting due to memory (Valgrind) errors. (Closed)

Created:
8 years, 9 months ago by James Hawkins

Modified:
8 years, 9 months ago

Reviewers:
scheib

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Reverting due to memory (Valgrind) errors. Revert 129448 - Automated tests for full screen & mouse lock M16 features Tests added to browsertest to improve coverage for fullscreen and mouse lock transitions. Several helper functions added to BrowserTest. Removes need to friend many tests and simplifies tests to increases readability. IsFullscreenForTab() removed globally leaving only IsFullscreenForTabOrPending. IsFullscreenForBrowser() added to fullscreen controller to enable testing. typedef BrowserWithTestWindowTest BrowserTest; removed due to name conflict. BUG=100678 TEST= Review URL: http://codereview.chromium.org/9702055 TBR=scheib@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129474

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -306 lines)			Patch
MM	chrome/browser/ui/browser.h	View	3 chunks	+7 lines, -7 lines	0 comments	Download
MM	chrome/browser/ui/browser.cc	View	2 chunks	+3 lines, -7 lines	0 comments	Download
MM	chrome/browser/ui/browser_browsertest.cc	View	12 chunks	+55 lines, -257 lines	0 comments	Download
MM	chrome/browser/ui/browser_unittest.cc	View	3 chunks	+4 lines, -2 lines	0 comments	Download
MM	chrome/browser/ui/cocoa/browser_window_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	chrome/browser/ui/cocoa/browser_window_controller_private.mm	View	3 chunks	+3 lines, -3 lines	0 comments	Download
MM	chrome/browser/ui/fullscreen_controller.h	View	1 chunk	+2 lines, -13 lines	0 comments	Download
MM	chrome/browser/ui/fullscreen_controller.cc	View	4 chunks	+10 lines, -10 lines	0 comments	Download
MM	chrome/browser/ui/tests/browser_uitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/web_contents_delegate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/web_contents_delegate.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages