Issue 9875019: Adjust to version of grit where default is no resource_ids file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9875019: Adjust to version of grit where default is no resource_ids file. (Closed)

Created:
8 years, 9 months ago by Jói

Modified:
8 years, 8 months ago

Reviewers:
tony

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pick up and adjust to version of grit where default is no resource_ids file. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129619 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130115

Patch Set 1 #

Patch Set 2 : Merge to LKGR (pure merge). #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	build/grit_action.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/debugger/devtools_resources.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jói

Tony, this is dependent on http://codereview.chromium.org/9802029/ landing first in the grit-i18n repo. Hopefully by the ...

8 years, 9 months ago (2012-03-28 14:43:51 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/9875019/3001

8 years, 8 months ago (2012-03-29 11:37:53 UTC) #3

commit-bot: I haz the power

8 years, 8 months ago (2012-03-29 11:45:43 UTC) #4

Try job failure for 9875019-3001 on linux_clang for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Expand Messages | Collapse Messages