Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8316)

Unified Diff: chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp

Issue 9875010: nss: Fix GetCertType returning SERVER_CERT for explicitly distrusted CA certs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review changes, add server testcase Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
diff --git a/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp b/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
index 2f9a4e9e017e5064a1aa721dea83e59cc48a789c..56565fceaf77c39f23ae6b4f86b30f5eacfed25e 100644
--- a/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
+++ b/chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp
@@ -1056,12 +1056,10 @@ net::CertType GetCertType(CERTCertificate *cert) {
nsNSSCertTrust trust(cert->trust);
if (cert->nickname && trust.HasAnyUser())
return net::USER_CERT;
- if (trust.HasAnyCA())
+ if (trust.HasAnyCA() || CERT_IsCACert(cert, NULL))
return net::CA_CERT;
if (trust.HasPeer(PR_TRUE, PR_FALSE, PR_FALSE))
return net::SERVER_CERT;
- if (CERT_IsCACert(cert, NULL))
- return net::CA_CERT;
return net::UNKNOWN_CERT;
}

Powered by Google App Engine
This is Rietveld 408576698