Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 9874017: Restart the Chrome session after a successful KIOSK enrollment. (Closed)

Created:
8 years, 9 months ago by pastarmovj
Modified:
8 years, 9 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Restart the Chrome session after a successful KIOSK enrollment. BUG=chromium-os:28586 TEST=Enroll in KIOSK mode and ensure the session restarts when enrollment is done. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129396

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.cc View 2 chunks +11 lines, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
pastarmovj
Can you bless this one please?
8 years, 9 months ago (2012-03-28 11:20:26 UTC) #1
Joao da Silva
lgtm http://codereview.chromium.org/9874017/diff/1/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.cc File chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.cc (right): http://codereview.chromium.org/9874017/diff/1/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.cc#newcode86 chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.cc:86: GetDeviceCloudPolicyDataStore()->device_mode() == How about just browser_policy_connector()->GetDeviceMode()? I'm just ...
8 years, 9 months ago (2012-03-28 11:36:37 UTC) #2
pastarmovj
8 years, 9 months ago (2012-03-28 11:43:15 UTC) #3
http://codereview.chromium.org/9874017/diff/1/chrome/browser/chromeos/login/e...
File chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.cc
(right):

http://codereview.chromium.org/9874017/diff/1/chrome/browser/chromeos/login/e...
chrome/browser/chromeos/login/enrollment/enterprise_enrollment_screen.cc:86:
GetDeviceCloudPolicyDataStore()->device_mode() ==
On 2012/03/28 11:36:37, Joao da Silva wrote:
> How about just browser_policy_connector()->GetDeviceMode()?
> 
> I'm just not sure the EnterpriseInstallAttributes will get the right values
> right after enrollment.

They must have the right value if registration has succeeded or else we will not
fetch policy. The race Mattias is working on is much earlier in the flow. At
this point in code we discuss here we are in very deep horse-dong if the
InstallAttribs are not yet in sync :)

Powered by Google App Engine
This is Rietveld 408576698