[Sync] [GTK] Add GTK version of the one-click signin dialog

[Sync] [GTK] Add GTK version of the one-click signin dialog

Enable one-click signin on Linux (but not ChromeOS).

Build GTK version of one-click signin dialog.

BUG=120577
TEST=On Linux, with a clean profile, sign into GMail.  The one-click infobar should pop up, and clicking "OK, sync" should bring up the one-click dialog.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129762

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129773

[akalin, 2012-03-28 00:59:34]

+estade for gtk stuff
+rogerta for general review

[akalin, 2012-03-28 01:03:40]

On 2012/03/28 00:59:34, akalin wrote:
> +estade for gtk stuff
> +rogerta for general review

Screenshot of dialog is in the linked bug.

[Roger Tawa OOO till Jul 10th, 2012-03-28 01:10:01]

lgtm

[Evan Stade, 2012-03-28 21:27:29]

http://codereview.chromium.org/9874006/diff/4001/chrome/browser/ui/gtk/one_cl...
File chrome/browser/ui/gtk/one_click_signin_dialog_gtk.cc (right):

http://codereview.chromium.org/9874006/diff/4001/chrome/browser/ui/gtk/one_cl...
chrome/browser/ui/gtk/one_click_signin_dialog_gtk.cc:27:
use_default_settings_checkbox_(
I'd rather you define these inside the constructor than in the initializer list
because this is sort of hard to read. Plus it's better to initialize near where
it's used.

http://codereview.chromium.org/9874006/diff/4001/chrome/browser/ui/gtk/one_cl...
chrome/browser/ui/gtk/one_click_signin_dialog_gtk.cc:34: GtkWidget* ok_button =
gtk_dialog_add_button(
ok button goes after cancel button on gtk (and mac)

[akalin, 2012-03-29 08:38:54]

All comments addressed, PTAL

http://codereview.chromium.org/9874006/diff/4001/chrome/browser/ui/gtk/one_cl...
File chrome/browser/ui/gtk/one_click_signin_dialog_gtk.cc (right):

http://codereview.chromium.org/9874006/diff/4001/chrome/browser/ui/gtk/one_cl...
chrome/browser/ui/gtk/one_click_signin_dialog_gtk.cc:27:
use_default_settings_checkbox_(
On 2012/03/28 21:27:29, Evan Stade wrote:
> I'd rather you define these inside the constructor than in the initializer
list
> because this is sort of hard to read. Plus it's better to initialize near
where
> it's used.

Done.

http://codereview.chromium.org/9874006/diff/4001/chrome/browser/ui/gtk/one_cl...
chrome/browser/ui/gtk/one_click_signin_dialog_gtk.cc:34: GtkWidget* ok_button =
gtk_dialog_add_button(
On 2012/03/28 21:27:29, Evan Stade wrote:
> ok button goes after cancel button on gtk (and mac)

Done.

[Evan Stade, 2012-03-29 20:51:01]

lgtm

[akalin, 2012-03-30 02:27:22]

On 2012/03/29 20:51:01, Evan Stade wrote:
> lgtm

This broke the chromeos build -- i think i inadvertently turned it in for it.

[tfarina, 2012-03-30 21:45:17]

https://chromiumcodereview.appspot.com/9874006/diff/16001/chrome/browser/ui/g...
File chrome/browser/ui/gtk/one_click_signin_dialog_gtk.h (right):

https://chromiumcodereview.appspot.com/9874006/diff/16001/chrome/browser/ui/g...
chrome/browser/ui/gtk/one_click_signin_dialog_gtk.h:9: #include
"chrome/browser/ui/sync/one_click_signin_dialog.h"
nit: hum? this should be sorted with the other includes below.

https://chromiumcodereview.appspot.com/9874006/diff/16001/chrome/browser/ui/g...
chrome/browser/ui/gtk/one_click_signin_dialog_gtk.h:12: #include
"base/callback.h"
nit: can't you forward declare this because of |accept_callback_|?