Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 9873029: Fix IME support for --enable-threaded-compositing (Closed)

Created:
8 years, 9 months ago by jonathan.backer
Modified:
8 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, kinaba
Visibility:
Public.

Description

Fix IME support for --enable-threaded-compositing The threaded compositor bypasses RenderWidget::DoDeferredUpdate(). Added two calls in RenderWidget::willBeginCompositorFrame() that are normally called in DoDeferredUpdate to support IME. BUG=120361 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129489

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/renderer/render_widget.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jonathan.backer
nduca@ for review (I think this logic is your doing). piman@ for OWNERS
8 years, 9 months ago (2012-03-28 15:37:24 UTC) #1
jamesr
lgtm
8 years, 9 months ago (2012-03-28 16:30:59 UTC) #2
piman
lgtm https://chromiumcodereview.appspot.com/9873029/diff/1/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://chromiumcodereview.appspot.com/9873029/diff/1/content/renderer/render_widget.cc#newcode1115 content/renderer/render_widget.cc:1115: void RenderWidget::willBeginCompositorFrame() { Just to double-check, this is ...
8 years, 9 months ago (2012-03-28 16:45:49 UTC) #3
nduca
http://codereview.chromium.org/9873029/diff/1/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): http://codereview.chromium.org/9873029/diff/1/content/renderer/render_widget.cc#newcode1115 content/renderer/render_widget.cc:1115: void RenderWidget::willBeginCompositorFrame() { On 2012/03/28 16:45:50, piman wrote: > ...
8 years, 9 months ago (2012-03-28 18:01:12 UTC) #4
nduca
LGTM
8 years, 9 months ago (2012-03-28 18:01:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/9873029/3003
8 years, 9 months ago (2012-03-28 19:02:49 UTC) #6
Emmanuel Saint-loubert-Bié
On 2012/03/28 19:02:49, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
8 years, 9 months ago (2012-03-28 20:02:11 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 21:11:12 UTC) #8
Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

Powered by Google App Engine
This is Rietveld 408576698