Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: tools/check-static-initializers.sh

Issue 9873023: Fix performance regressions due to lazy initialization. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Make init traits non-template structs. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/v8.cc ('k') | tools/gyp/v8.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/bin/bash 1 #!/bin/bash
2 # Copyright 2012 the V8 project authors. All rights reserved. 2 # Copyright 2012 the V8 project authors. All rights reserved.
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following 10 # copyright notice, this list of conditions and the following
(...skipping 13 matching lines...) Expand all
24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 28
29 # Checks that the number of compilation units having at least one static 29 # Checks that the number of compilation units having at least one static
30 # initializer in d8 matches the one defined below. 30 # initializer in d8 matches the one defined below.
31 # Note that the project must be built with SCons before running this script. 31 # Note that the project must be built with SCons before running this script.
32 32
33 # Allow: 33 # Allow:
34 # - _GLOBAL__I__ZN2v810LineEditor6first_E
34 # - _GLOBAL__I__ZN2v88internal32AtomicOps_Internalx86CPUFeaturesE 35 # - _GLOBAL__I__ZN2v88internal32AtomicOps_Internalx86CPUFeaturesE
35 # - _GLOBAL__I__ZN2v810LineEditor6first_E 36 # - _GLOBAL__I__ZN2v88internal8ThreadId18highest_thread_id_E
36 expected_static_init_count=2 37 expected_static_init_count=3
37 38
38 v8_root=$(readlink -f $(dirname $BASH_SOURCE)/../) 39 v8_root=$(readlink -f $(dirname $BASH_SOURCE)/../)
39 d8="${v8_root}/d8" 40 d8="${v8_root}/d8"
40 41
41 if [ ! -f "$d8" ]; then 42 if [ ! -f "$d8" ]; then
42 echo "Please build the project with SCons." 43 echo "Please build the project with SCons."
43 exit 1 44 exit 1
44 fi 45 fi
45 46
46 static_inits=$(nm "$d8" | grep _GLOBAL__I | awk '{ print $NF; }') 47 static_inits=$(nm "$d8" | grep _GLOBAL__I | awk '{ print $NF; }')
47 48
48 static_init_count=$(echo "$static_inits" | wc -l) 49 static_init_count=$(echo "$static_inits" | wc -l)
49 50
50 if [ $static_init_count -gt $expected_static_init_count ]; then 51 if [ $static_init_count -gt $expected_static_init_count ]; then
51 echo "Too many static initializers." 52 echo "Too many static initializers."
52 echo "$static_inits" 53 echo "$static_inits"
53 exit 1 54 exit 1
54 fi 55 fi
OLDNEW
« no previous file with comments | « src/v8.cc ('k') | tools/gyp/v8.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698