Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 9873020: ash: Do not show the arrow in the tray bubbles when the tray isn't visible. (Closed)

Created:
8 years, 9 months ago by sadrul
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org, James Cook
Visibility:
Public.

Description

ash: Do not show the arrow in the tray bubbles when the tray isn't visible. BUG=120140 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129483

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -21 lines) Patch
M ash/system/tray/system_tray.cc View 1 1 chunk +23 lines, -21 lines 0 comments Download
M ash/wm/shelf_layout_manager.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
http://codereview.chromium.org/9873020/diff/1/ash/system/tray/system_tray.cc File ash/system/tray/system_tray.cc (right): http://codereview.chromium.org/9873020/diff/1/ash/system/tray/system_tray.cc#newcode224 ash/system/tray/system_tray.cc:224: internal::ShelfLayoutManager::AUTO_HIDE_SHOWN)) { Is there a better way of determining ...
8 years, 9 months ago (2012-03-28 05:38:47 UTC) #1
sky
LGTM. I filed a bug on this a while back (120140). You'll likely want to ...
8 years, 9 months ago (2012-03-28 15:31:11 UTC) #2
sadrul
I have added ShelfLayoutManager::IsVisible, as suggested. Another look please?
8 years, 9 months ago (2012-03-28 18:24:49 UTC) #3
sky
8 years, 9 months ago (2012-03-28 20:23:53 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698