Issue 9873013: Move PrintDialogCloud.HandlersRegistered test to interactive_ui_tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9873013: Move PrintDialogCloud.HandlersRegistered test to interactive_ui_tests (Closed)

Created:
8 years, 9 months ago by Scott Byer

Modified:
8 years, 8 months ago

Reviewers:
Albert Bodenhamer

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move PrintDialogCloud.HandlersRegistered test to interactive_ui_tests Tests that use SendKeyPress should not be in browser_tests. BUG=120578 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129465

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -264 lines)			Patch
A +	chrome/browser/printing/print_dialog_cloud_interative_uitest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/browser/printing/print_dialog_cloud_uitest.cc	View	1 chunk	+0 lines, -264 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Albert Bodenhamer

lgtm On Tue, Mar 27, 2012 at 6:03 PM, <scottbyer@chromium.org> wrote: > Reviewers: Albert Bodenhamer, ...

8 years, 9 months ago (2012-03-28 01:12:47 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottbyer@chromium.org/9873013/1

8 years, 9 months ago (2012-03-28 01:22:25 UTC) #3

commit-bot: I haz the power

8 years, 9 months ago (2012-03-28 01:22:28 UTC) #4

Presubmit check for 9873013-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
New code should not use ScopedAllowIO. Post a task to the blocking pool or the
FILE thread instead.
    chrome/browser/printing/print_dialog_cloud_interative_uitest.cc:49

Expand Messages | Collapse Messages