Move member-iterating code into ClassElement.

frog/leg/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 898 matching lines @@
 
     final Map<FunctionElement, TreeElements> constructorElements =
         compiler.resolver.constructorElements;
     List<FunctionElement> constructors = new List<FunctionElement>();
 
     // Analyze the constructor and all referenced constructors and collect
     // initializers and constructor bodies.
     inlineInitializers(functionElement, constructors, fieldValues);
 
     // Call the JavaScript constructor with the fields as argument.
-    // TODO(floitsch,karlklose): move this code to ClassElement and share with
-    //                           the emitter.
     List<HInstruction> constructorArguments = <HInstruction>[];
-    ClassElement element = classElement;
-    while (element != null) {
-      for (Element member in element.members) {
-        if (member.isInstanceMember() && member.kind == ElementKind.FIELD) {
-          HInstruction value = fieldValues[member];
-          if (value === null) {
-            // The field has no value in the initializer list. Initialize it
-            // with the declaration-site constant (if any).
-            Constant fieldValue =
-                compiler.constantHandler.compileVariable(member);
-            value = graph.addConstant(fieldValue);
-          }
-          constructorArguments.add(value);
-        }
+    classElement.forEachInstanceField(
+        includeBackendMembers: true,
+        includeSuperMembers: true,
+        f: (ClassElement enclosingClass, Element member) {
+      HInstruction value = fieldValues[member];
+      if (value === null) {
+        // The field has no value in the initializer list. Initialize it
+        // with the declaration-site constant (if any).
+        Constant fieldValue = compiler.constantHandler.compileVariable(member);
+        value = graph.addConstant(fieldValue);
       }
-      element = element.superclass;
-    }
+      constructorArguments.add(value);
+    });
+  
     HForeignNew newObject = new HForeignNew(classElement, constructorArguments);
     add(newObject);
     // Generate calls to the constructor bodies.
     for (int index = constructors.length - 1; index >= 0; index--) {
       FunctionElement constructor = constructors[index];
       // TODO(floitsch): find better way to detect that constructor body is
       // empty.
       if (constructor is SynthesizedConstructorElement) continue;
       ConstructorBodyElement body = getConstructorBody(classElement,
                                                        constructor);
@@ skipping 2013 matching lines @@
                                         false,
                                         <HInstruction>[target, input]));
     return builder.pop();
   }
 
   HInstruction result() {
     flushLiterals();
     return prefix;
   }
 }