Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 9873005: [Coverity] Fix possible leak. (Closed)

Created:
8 years, 9 months ago by groby-ooo-7-16
Modified:
8 years, 8 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

[Coverity] Fix possible leak. If the first open returns a file handle of 0, it could be leaked (if PLATFORM_FILE_OPEN_ALWAYS is set too) In general, fixed so that file handle of 0 is treated as a file handle, not as error code. CID=101981 BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129659

Patch Set 1 #

Patch Set 2 : Fixed (c) year #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M base/platform_file_posix.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
groby-ooo-7-16
8 years, 9 months ago (2012-03-27 22:01:37 UTC) #1
darin (slow to review)
LGTM
8 years, 9 months ago (2012-03-27 23:24:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/9873005/1
8 years, 9 months ago (2012-03-28 02:01:21 UTC) #3
commit-bot: I haz the power
Try job failure for 9873005-1 (retry) (retry) on win_rel for step "browser_tests". It's a second ...
8 years, 9 months ago (2012-03-28 06:27:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/9873005/1
8 years, 8 months ago (2012-03-28 16:57:11 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-03-28 22:46:52 UTC) #6
Try job failure for 9873005-1 (retry) (retry) (retry) on win_rel for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698