Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 9866050: Update expectations in a json_schema_compiler unit test (Closed)

Created:
8 years, 9 months ago by asargent_no_longer_on_chrome
Modified:
8 years, 9 months ago
Reviewers:
miket_OOO, Garret Kelly
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Fixes to json_schema_compiler unit tests These are necessary after the changes that went in with crrev.com/129042 (http://codereview.chromium.org/9836078) Update: also fix some fallout from crrev.com/129251 BUG=120481 TEST=(this is a test) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129482

Patch Set 1 #

Patch Set 2 : removed spurious whitespace only change #

Patch Set 3 : fixed new problems from crrev.com/129251 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -30 lines) Patch
M tools/json_schema_compiler/cpp_type_generator.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/cpp_type_generator_test.py View 1 2 6 chunks +36 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
asargent_no_longer_on_chrome
8 years, 9 months ago (2012-03-27 19:17:14 UTC) #1
Garret Kelly
LGTM Thanks for fixing this!
8 years, 9 months ago (2012-03-27 19:25:18 UTC) #2
asargent_no_longer_on_chrome
New version uploaded with a couple of extra fixes - can you take a quick ...
8 years, 9 months ago (2012-03-27 22:10:27 UTC) #3
Garret Kelly
On 2012/03/27 22:10:27, Antony Sargent wrote: > New version uploaded with a couple of extra ...
8 years, 9 months ago (2012-03-27 22:12:25 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-28 03:47:39 UTC) #5
asargent_no_longer_on_chrome
+miket - Mike, can you review also since Garret isn't full committer yet?
8 years, 9 months ago (2012-03-28 05:33:57 UTC) #6
miket_OOO
8 years, 9 months ago (2012-03-28 19:46:16 UTC) #7
Lgtm

Powered by Google App Engine
This is Rietveld 408576698