Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 9866048: [Sync] [Mac] Tweak OneClickSigninDialog nib (Closed)

Created:
8 years, 9 months ago by akalin
Modified:
8 years, 9 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Visibility:
Public.

Description

[Sync] [Mac] Tweak OneClickSigninDialog nib Make 'Enter' press the 'Start Syncing' button. Define the tab order Cancel -> Start Syncing -> (use defaults checkbox) -> Cancel. BUG=117899, 116685 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129366

Patch Set 1 #

Patch Set 2 : Resave in snolo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M chrome/app/nibs/OneClickSigninDialog.xib View 1 4 chunks +35 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
akalin
+rsesek for review I'll need you to resave this in 10.6, also.
8 years, 9 months ago (2012-03-27 18:40:22 UTC) #1
akalin
On 2012/03/27 18:40:22, akalin wrote: > +rsesek for review > > I'll need you to ...
8 years, 9 months ago (2012-03-27 19:57:30 UTC) #2
akalin
On 2012/03/27 19:57:30, akalin wrote: > On 2012/03/27 18:40:22, akalin wrote: > > +rsesek for ...
8 years, 9 months ago (2012-03-27 23:57:39 UTC) #3
Robert Sesek
lgtm
8 years, 9 months ago (2012-03-28 00:02:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9866048/5001
8 years, 9 months ago (2012-03-28 00:03:33 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 02:47:28 UTC) #6
Try job failure for 9866048-5001 (retry) (previous was lost) on win_rel for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698