Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 9866046: Fix test harness for Test262 to not use symlinks. (Closed)

Created:
8 years, 9 months ago by Michael Starzinger
Modified:
8 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix test harness for Test262 to not use symlinks. This is necessary for the --download-data option to work on Windows where we do not have symlinks available. Note that we still have no automatic way of bumping the existing Test262 revision without deleting the data directory manually. R=jkummerow@chromium.org TEST=test262 Committed: https://code.google.com/p/v8/source/detail?r=11172

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Jakob Kummerow. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M test/test262/testcfg.py View 1 2 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
8 years, 9 months ago (2012-03-27 17:11:03 UTC) #1
Jakob Kummerow
LGTM. Here's an idea for automatic updating: - When creating a 'data' directory, store the ...
8 years, 9 months ago (2012-03-28 08:06:10 UTC) #2
Michael Starzinger
8 years, 9 months ago (2012-03-28 09:29:29 UTC) #3
Yes, keeping the extracted revision in some kind of stamp file would certainly
do it. But then again, deleting the old "data" directory is the pain point on
Windows. So I am actually thinking about letting "gclient" do that for us every
time, because it has all the tricks to actually delete untracked directories in
SVN checkouts on all platforms. Then our test harness would just extract the
downloaded archive on every cycle, which takes about one minute. It wouldn't
repeat the download itself, because untracked files are left untouched by
"gclient".

Will do that in a separate CL once we bump Test262 to a new version for the
first time (do it lazily according to the spirit of V8).

https://chromiumcodereview.appspot.com/9866046/diff/1/test/test262/testcfg.py
File test/test262/testcfg.py (right):

https://chromiumcodereview.appspot.com/9866046/diff/1/test/test262/testcfg.py...
test/test262/testcfg.py:1: # Copyright 2011 the V8 project authors. All rights
reserved.
On 2012/03/28 08:06:10, Jakob wrote:
> 2012

Done.

Powered by Google App Engine
This is Rietveld 408576698