Issue 9866006: Add library mapping.

Issue 9866006: Add library mapping. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, mattsh, compiler-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add library mapping. Committed: https://code.google.com/p/dart/source/detail?r=5935

Patch Set 2 : Rebased #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -54 lines)			Patch
M	dart/frog/tests/leg/src/mock_compiler.dart	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	dart/lib/compiler/implementation/apiimpl.dart	View	1	3 chunks	+14 lines, -22 lines	0 comments	Download
M	dart/lib/compiler/implementation/compiler.dart	View	1	3 chunks	+4 lines, -6 lines	0 comments	Download
M	dart/lib/compiler/implementation/dart2js.dart	View	1	3 chunks	+7 lines, -2 lines	0 comments	Download
M	dart/lib/compiler/implementation/frog_leg.dart	View	1	3 chunks	+10 lines, -3 lines	0 comments	Download
D	dart/lib/compiler/implementation/io/io.dart	View	1	1 chunk	+0 lines, -15 lines	0 comments	Download
A	dart/lib/compiler/implementation/library_map.dart	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
M	dart/lib/compiler/implementation/scanner/scanner_task.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	dart/utils/compiler/build_helper.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ahe

https://chromiumcodereview.appspot.com/9866006/diff/2001/dart/frog/leg/frog_leg.dart File dart/frog/leg/frog_leg.dart (right): https://chromiumcodereview.appspot.com/9866006/diff/2001/dart/frog/leg/frog_leg.dart#newcode103 dart/frog/leg/frog_leg.dart:103: String getCurrentDirectory() { Duplicated code. This file will go ...

8 years, 9 months ago (2012-03-26 21:39:33 UTC) #1

ahe

I was doing this CL while chatting to Matt and he keep finding problems in ...

8 years, 9 months ago (2012-03-26 21:43:41 UTC) #2

zundel

https://chromiumcodereview.appspot.com/9866006/diff/2001/dart/frog/leg/library_map.dart File dart/frog/leg/library_map.dart (right): https://chromiumcodereview.appspot.com/9866006/diff/2001/dart/frog/leg/library_map.dart#newcode24 dart/frog/leg/library_map.dart:24: }; This looks just like the .property files we ...

8 years, 9 months ago (2012-03-26 22:08:20 UTC) #3

ahe

Hi Kasper and Eric, Thank you for taking a look. Cheers, Peter https://chromiumcodereview.appspot.com/9866006/diff/2001/dart/frog/leg/library_map.dart File dart/frog/leg/library_map.dart ...

8 years, 9 months ago (2012-03-28 15:31:43 UTC) #5

zundel

8 years, 9 months ago (2012-03-28 15:33:20 UTC) #6

lgtm2
we an address a common mapping format later.

On 2012/03/28 15:31:43, ahe wrote:
> Hi Kasper and Eric,
> 
> Thank you for taking a look.
> 
> Cheers,
> Peter
> 
>
https://chromiumcodereview.appspot.com/9866006/diff/2001/dart/frog/leg/librar...
> File dart/frog/leg/library_map.dart (right):
> 
>
https://chromiumcodereview.appspot.com/9866006/diff/2001/dart/frog/leg/librar...
> dart/frog/leg/library_map.dart:24: };
> On 2012/03/26 22:08:20, zundel wrote:
> > This looks just like the .property files we are cooking up for the editor. 
> I'd
> > like to use a common format between all platforms to keep everything
> seamlessly
> > in sync, which we can mull over once we get the dart2js libs in dart-sdk.
> 
> I don't mind a common format, I'm using a const map in the name of short-term
> expediency.

Expand Messages | Collapse Messages