Force _HAS_TR1=0 only on VS2008

Remove forced _HAS_TR1=0 define. VS2010 headers unconditionally define _HAS_TR1=1. The gyp msvs 2010 generator has a hardcoded hack to remove _HAS_TR1=0 from the defines, but it seems better not to add this to the ninja generator too.

Added here http://codereview.chromium.org/147015/ but not sure of reason. Perhaps the define could just be removed now?

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129310

[M-A Ruel, 2012-03-27 18:50:49]

lgtm, thanks

[commit-bot: I haz the power, 2012-03-27 23:42:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/9865029/2001

[commit-bot: I haz the power, 2012-03-28 00:00:16]

Try job failure for 9865029-2001 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[Nico, 2012-05-04 18:00:49]

native_client/build/common.gypi needs this change too. (And since changing this
seems to be a bit involved, maybe try removing it for good?)

[scottmg, 2012-05-04 18:02:49]

On 2012/05/04 18:00:49, Nico wrote:
> native_client/build/common.gypi needs this change too. (And since changing
this
> seems to be a bit involved, maybe try removing it for good?)

http://chromiumcodereview.appspot.com/10264015/

[Nico, 2012-05-04 18:04:46]

On Fri, May 4, 2012 at 11:02 AM,  <scottmg@chromium.org> wrote:
> On 2012/05/04 18:00:49, Nico wrote:
>>
>> native_client/build/common.gypi needs this change too. (And since changing
>
> this
>>
>> seems to be a bit involved, maybe try removing it for good?)
>
>
> http://chromiumcodereview.appspot.com/10264015/
>
> http://chromiumcodereview.appspot.com/9865029/

Ah, cool. I think I have the NaCl commit bit, so I can land that for
you if it hasn't happened yet.

[scottmg, 2012-05-04 18:05:27]

Thanks, please do!

On Fri, May 4, 2012 at 11:04 AM, Nico Weber <thakis@chromium.org> wrote:
> On Fri, May 4, 2012 at 11:02 AM,  <scottmg@chromium.org> wrote:
>> On 2012/05/04 18:00:49, Nico wrote:
>>>
>>> native_client/build/common.gypi needs this change too. (And since changing
>>
>> this
>>>
>>> seems to be a bit involved, maybe try removing it for good?)
>>
>>
>> http://chromiumcodereview.appspot.com/10264015/
>>
>> http://chromiumcodereview.appspot.com/9865029/
>
> Ah, cool. I think I have the NaCl commit bit, so I can land that for
> you if it hasn't happened yet.