Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 9865015: Make renderer calls into script declare there "type" (internal or author). (Closed)

Created:
8 years, 9 months ago by rafaelw
Modified:
8 years, 8 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org, abarth-chromium
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make renderer calls into script declare there "type" (internal or author). Script invocations into contexts which host author script (i.e. context owned by webkit) must now take one of two paths: 1) For calls which may run author scripts -> call through WebFrame 2) For calls which can not run author script -> call directly, but whitelist the call with a stack-allocated WebScopedMicrotaskSuppression. This patch must wait on https://bugs.webkit.org/show_bug.cgi?id=79131 rolling in. Once this patch is landed, a final patch will be committed to webkit which enables a debug-only check which enforces correct usage and will cause an ASSERTION failure on the test bots if code is committed which does not. BUG=112892 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131425

Patch Set 1 #

Patch Set 2 : pre-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/renderer/extensions/chrome_v8_context.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M chrome/renderer/extensions/miscellaneous_bindings.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/renderer/module_system.cc View 1 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rafaelw
8 years, 8 months ago (2012-04-04 00:41:42 UTC) #1
Matt Perry
lgtm
8 years, 8 months ago (2012-04-04 18:59:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rafaelw@chromium.org/9865015/2001
8 years, 8 months ago (2012-04-06 17:55:35 UTC) #3
commit-bot: I haz the power
Try job failure for 9865015-2001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-06 20:04:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rafaelw@chromium.org/9865015/2001
8 years, 8 months ago (2012-04-09 18:28:04 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-09 20:39:54 UTC) #6
Change committed as 131425

Powered by Google App Engine
This is Rietveld 408576698