Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issue 9865010: Prevent state updates for kSwappedOutURL. (Closed)

Created:
8 years, 9 months ago by Charlie Reis
Modified:
8 years, 8 months ago
Reviewers:
jam, Matt Perry
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Prevent state updates for kSwappedOutURL. BUG=72235 TEST=See bug, comment 9 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M content/renderer/render_view_browsertest.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Charlie Reis
Matt, can you review?
8 years, 8 months ago (2012-03-27 16:30:28 UTC) #1
Matt Perry
lgtm
8 years, 8 months ago (2012-03-27 18:31:58 UTC) #2
Charlie Reis
John, can you review for owner's approval?
8 years, 8 months ago (2012-03-27 18:36:46 UTC) #3
jam
lgtm
8 years, 8 months ago (2012-03-27 19:21:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/9865010/1
8 years, 8 months ago (2012-03-27 19:36:35 UTC) #5
commit-bot: I haz the power
Try job failure for 9865010-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-03-27 20:38:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/9865010/1
8 years, 8 months ago (2012-03-27 23:22:23 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-03-27 23:35:56 UTC) #8
Try job failure for 9865010-1 (retry) on win_rel for step "update".
It's a second try, previously, step "update" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698