Issue 9865009: Run json_schema_compiler unit tests via a PRESUBMIT check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9865009: Run json_schema_compiler unit tests via a PRESUBMIT check. (Closed)

Created:
8 years, 9 months ago by asargent_no_longer_on_chrome

Modified:
8 years, 9 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, pam+watch_chromium.org, miket_OOO, not at google - send to devlin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Run json_schema_compiler unit tests via a PRESUBMIT check. As I noted in the bug, these unit tests had gotten broken by some recent changes because they weren't being run automatically. BUG=120308 TEST=(this is adding a presubmit test) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129484

Patch Set 1 #

Total comments: 1

Patch Set 2 : switched to using whitelist as suggested #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
A	tools/json_schema_compiler/PRESUBMIT.py	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
M	tools/json_schema_compiler/code_test.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/json_schema_compiler/cpp_type_generator_test.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/json_schema_compiler/cpp_util_test.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/json_schema_compiler/model_test.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

maruel: please review miket/kalman: FYI

8 years, 9 months ago (2012-03-26 23:57:20 UTC) #1

M-A Ruel

8 years, 9 months ago (2012-03-27 00:42:04 UTC) #2

lgtm

http://codereview.chromium.org/9865009/diff/1/tools/json_schema_compiler/PRES...
File tools/json_schema_compiler/PRESUBMIT.py (right):

http://codereview.chromium.org/9865009/diff/1/tools/json_schema_compiler/PRES...
tools/json_schema_compiler/PRESUBMIT.py:14: def CheckChangeOnUpload(input_api,
output_api):
Idea: you could use RunUnitTestsInDirectory with a whitelist=r'.+_test\.py'.

Expand Messages | Collapse Messages