tools/testing/dart/test_suite.dart - Issue 9864054: Demorgan's law application failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9864054: Demorgan's law application failure. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testing/dart/test_suite.dart

===================================================================

--- tools/testing/dart/test_suite.dart (revision 5906)

+++ tools/testing/dart/test_suite.dart (working copy)

@@ -519,7 +519,7 @@

// Construct the command(s) that compile all the inputs needed by the

// browser test. For running Dart in DRT, this will be noop commands.

List<Command> commands = [];

- if (compiler != 'none' || runtime == 'drt') {

+ if (compiler != 'none' && runtime != 'drt') {

Siggi Cherem (dart-lang) 2012/03/27 21:23:43 it seems to me that here we simply want compiler !

commands.add(_compileCommand(

dartWrapperFilename, compiledDartWrapperFilename,

compiler, tempDir.path, vmOptions));

« no previous file with comments | « no previous file | no next file » | no next file with comments »