Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 9864048: Add a border to views_examples' text styles example. (Closed)

Created:
8 years, 9 months ago by Alexei Svitkine (slow)
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Add a border to views_examples' text styles example. This makes it easy to see what size is being used to center/align the text, for example. BUG=none TEST=Open views_examples text styles example. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129451

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M ui/views/examples/text_example.cc View 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Alexei Svitkine (slow)
8 years, 9 months ago (2012-03-27 18:16:42 UTC) #1
sky
LGTM
8 years, 9 months ago (2012-03-27 20:08:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/9864048/1
8 years, 9 months ago (2012-03-27 20:11:01 UTC) #3
commit-bot: I haz the power
Failed to apply the patch.
8 years, 9 months ago (2012-03-27 22:45:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/9864048/1
8 years, 9 months ago (2012-03-27 22:57:54 UTC) #5
commit-bot: I haz the power
Try job failure for 9864048-1 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=4722 Step "update" is always ...
8 years, 9 months ago (2012-03-27 23:34:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/9864048/1
8 years, 9 months ago (2012-03-28 14:21:15 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 17:30:14 UTC) #8
Try job failure for 9864048-1 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698