Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 9864041: Sync: Ordering of Other Devices menu should be reverse chronological. (Closed)

Created:
8 years, 9 months ago by Patrick Dubroy
Modified:
8 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org
Visibility:
Public.

Description

Sync: Ordering of Other Devices menu should be reverse chronological. Sort sessions by modified_time, showing most recent first. BUG=119701 TEST=Manual. Open some new tabs on client A, and check the contents of the menu on client B. Client A should be at the top of the list. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129401

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/ui/webui/ntp/foreign_session_handler.cc View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Patrick Dubroy
Hey James, can you please review?
8 years, 9 months ago (2012-03-27 16:47:43 UTC) #1
Evan Stade
8 years, 9 months ago (2012-03-27 18:55:06 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698