Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 9864034: Valgrind cleanliness, part 5: Delete extensions on exit. (Closed)

Created:
8 years, 9 months ago by Sven Panne
Modified:
8 years, 8 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Valgrind cleanliness, part 5: Delete extensions on exit. This fixes 4 leaks, returning 196 bytes of lost memory. Committed: https://code.google.com/p/v8/source/detail?r=11184

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fixed extension ownership #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M src/api.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/api.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M src/extensions/externalize-string-extension.cc View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M src/extensions/gc-extension.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/v8.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 9 months ago (2012-03-27 11:20:35 UTC) #1
danno
8 years, 9 months ago (2012-03-27 11:56:27 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698