Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 9864032: [WebUI] Fix all CSS nits in chrome/browser/resources/chromeos. (Closed)

Created:
8 years, 9 months ago by Dan Beam
Modified:
8 years, 8 months ago
CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org, dcheng, Evan Stade
Visibility:
Public.

Description

[WebUI] Fix all CSS nits in chrome/browser/resources/chromeos. R=tbreisacher@chromium.org,xiyuan@chromium.org BUG=120369 TEST=No presubmit errors (well, other than data: related ones). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129607

Patch Set 1 #

Patch Set 2 : copyright fix #

Total comments: 2

Patch Set 3 : removing some copyright bumps #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Total comments: 1

Patch Set 6 : fix #

Patch Set 7 : removing screen_account_picker.css #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -120 lines) Patch
M chrome/browser/resources/chromeos/choose_mobile_network.css View 1 2 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay.css View 5 chunks +32 lines, -25 lines 0 comments Download
M chrome/browser/resources/chromeos/login/bubble.css View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/network_dropdown.css View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.css View 1 2 3 4 5 10 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_error_message.css View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/user_pod_row.css View 1 2 3 4 8 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/resources/chromeos/menu.css View 4 chunks +20 lines, -15 lines 0 comments Download
M chrome/browser/resources/chromeos/mobile_dialogs.css View 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/network_menu.css View 3 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/sim_unlock.css View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/wrench_menu.css View 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dan Beam
8 years, 9 months ago (2012-03-27 09:37:46 UTC) #1
Tyler Breisacher (Chromium)
lgtm
8 years, 9 months ago (2012-03-27 19:31:39 UTC) #2
Dan Beam
https://chromiumcodereview.appspot.com/9864032/diff/2001/chrome/browser/resources/chromeos/login/header_bar.css File chrome/browser/resources/chromeos/login/header_bar.css (right): https://chromiumcodereview.appspot.com/9864032/diff/2001/chrome/browser/resources/chromeos/login/header_bar.css#newcode1 chrome/browser/resources/chromeos/login/header_bar.css:1: /* Copyright (c) 2012 The Chromium Authors. All rights ...
8 years, 9 months ago (2012-03-27 20:53:18 UTC) #3
Dan Beam
+xiyuan for OWNERS
8 years, 9 months ago (2012-03-27 20:57:04 UTC) #4
xiyuan
lgtm
8 years, 9 months ago (2012-03-27 21:00:24 UTC) #5
Dan Beam
8 years, 8 months ago (2012-03-29 07:03:30 UTC) #6
https://chromiumcodereview.appspot.com/9864032/diff/11001/chrome/browser/reso...
File chrome/browser/resources/chromeos/login/oobe.css (right):

https://chromiumcodereview.appspot.com/9864032/diff/11001/chrome/browser/reso...
chrome/browser/resources/chromeos/login/oobe.css:521: padding: 20px 20px 130px;
whoops...

Powered by Google App Engine
This is Rietveld 408576698