Issue 9864030: Profiler experiments: remove "stable on startup" rule

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9864030: Profiler experiments: remove "stable on startup" rule (Closed)

Created:
8 years, 9 months ago by Jakob Kummerow

Modified:
8 years, 9 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Profiler experiments: remove "stable on startup" rule Committed: https://code.google.com/p/v8/source/detail?r=11164

Patch Set 2 : fix nit #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -23 lines)			Patch
M	src/full-codegen.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/runtime-profiler.h	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	src/runtime-profiler.cc	View	1	3 chunks	+1 line, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM with a nit. http://codereview.chromium.org/9864030/diff/1/src/runtime-profiler.cc File src/runtime-profiler.cc (right): http://codereview.chromium.org/9864030/diff/1/src/runtime-profiler.cc#newcode368 src/runtime-profiler.cc:368: if (FLAG_watch_ic_patching) { I would ...

8 years, 9 months ago (2012-03-27 11:51:13 UTC) #2

Jakob Kummerow

8 years, 9 months ago (2012-03-27 12:27:47 UTC) #3

Thanks for the review, landing.

https://chromiumcodereview.appspot.com/9864030/diff/1/src/runtime-profiler.cc
File src/runtime-profiler.cc (right):

https://chromiumcodereview.appspot.com/9864030/diff/1/src/runtime-profiler.cc...
src/runtime-profiler.cc:368: if (FLAG_watch_ic_patching) {
On 2012/03/27 11:51:13, ulan wrote:
> I would prefer
> if (!FLAG_watch_ic_patching) {
> ...
> }

Done.

Expand Messages | Collapse Messages

Issue 9864030: Profiler experiments: remove "stable on startup" rule (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix nit #

Messages