utils/tests/pub/pub.status - Issue 9863057: Add DirectoryTestSuite.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: utils/tests/pub/pub.status

Issue 9863057: Add DirectoryTestSuite. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Oops. Add changes. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

	2 # for details. All rights reserved. Use of this source code is governed by a

	3 # BSD-style license that can be found in the LICENSE file.

	4

	5 [ $runtime == drt \|\| $runtime == ie \|\| $runtime == chrome \|\| $runtime == safari \|\| $runtime == ff \|\| $runtime == opera ]
	Emily Fortuna 2012/03/28 23:10:11 also $runtime == d8 (we also want to skip) also $runtime == d8 (we also want to skip) Emily Fortuna 2012/03/28 23:18:13 Here's a more concise way of saying (effectively) Show quoted text On 2012/03/28 23:10:11, Emily Fortuna wrote: > also $runtime == d8 (we also want to skip) Here's a more concise way of saying (effectively) the same thing: [$compiler == frog \|\| $compiler == dart2js \|\| $compiler == dartc \|\| $compiler == frogsh ] : Skip Bill Hesse* 2012/03/28 23:37:30 Is this an indication that we really need to add n Is this an indication that we really need to add negation to the status expression logic? I left it out, because I thought that this case would not happen. On 2012/03/28 23:18:13, Emily Fortuna wrote: Show quoted text > On 2012/03/28 23:10:11, Emily Fortuna wrote: > > also $runtime == d8 (we also want to skip) > > Here's a more concise way of saying (effectively) the same thing: > [$compiler == frog \|\| $compiler == dart2js \|\| $compiler == dartc \|\| $compiler == > frogsh ] > : Skip Bob Nystrom* 2012/03/29 00:10:17 Done. Show quoted text On 2012/03/28 23:18:13, Emily Fortuna wrote: > On 2012/03/28 23:10:11, Emily Fortuna wrote: > > also $runtime == d8 (we also want to skip) > > Here's a more concise way of saying (effectively) the same thing: > [$compiler == frog \|\| $compiler == dart2js \|\| $compiler == dartc \|\| $compiler == > frogsh ] > : Skip Done. Bob Nystrom* 2012/03/29 00:10:17 I thought about just adding "!=" support to test.d Show quoted text On 2012/03/28 23:37:30, Bill Hesse wrote: > Is this an indication that we really need to add negation to the status > expression logic? I left it out, because I thought that this case would not > happen. > > > On 2012/03/28 23:18:13, Emily Fortuna wrote: > > On 2012/03/28 23:10:11, Emily Fortuna wrote: > > > also $runtime == d8 (we also want to skip) > > > > Here's a more concise way of saying (effectively) the same thing: > > [$compiler == frog \|\| $compiler == dart2js \|\| $compiler == dartc \|\| $compiler > == > > frogsh ] > > *: Skip > I thought about just adding "!=" support to test.dart for this, but I figured I was making enough changes in this patch as it is. I can do that in another patch if you'd like.
	6 *: Skip # Pub only runs on the VM.

OLD	NEW

« tools/testing/dart/test_suite.dart ('K') | « tools/testing/dart/test_suite.dart ('k') | utils/tests/pub/pub_tests.dart » ('j') | utils/tests/pub/pub_tests.dart » ('J')