Add DirectoryTestSuite.

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 168 matching lines @@
   bool isNegativeIfChecked;
   bool hasFatalTypeErrors;
   bool hasRuntimeErrors;
   Set<String> multitestOutcome;
 
   TestInformation(this.filename, this.optionsFromFile, this.isNegative,
                   this.isNegativeIfChecked, this.hasFatalTypeErrors,
                   this.hasRuntimeErrors, this.multitestOutcome);
 }
 
+
 /**
  * A standard [TestSuite] implementation that searches for tests in a
  * directory, and creates [TestCase]s that compile and/or run them.
  */
 class StandardTestSuite implements TestSuite {
   Map configuration;
   String suiteName;
   String directoryPath;
   List<String> statusFilePaths;
   Function doTest;
@@ skipping 719 matching lines @@
         dir.onDone = (ignore) => activityCompleted();
         dir.list(recursive: listRecursively());
       }
     }
     // Completed the enqueueing of listers.
     activityCompleted();
   }
 }
 
 
+/**
+ * A standard test suite whose file organization matches an expected structure.
+ * To use this, your suite should look like:
+ *
+ *     dart/
+ *       path/
+ *         to/
+ *           mytestsuite/
+ *             mytestsuite.status
+ *             example1_tests.dart
+ *             example2_tests.dart
+ *             example3_tests.dart
+ *
+ * The important parts:
+ *
+ * * The leaf directory name is the name of your test suite.
+ * * The status file uses the same name.
+ * * Test files are directly in that directory and end in "_tests.dart".
+ *
+ * If you follow that convention, then you can construct one of these like:
+ *
+ *     new DirectoryTestSuite(configuration, 'path/to/mytestsuite');
+ *
+ * instead of having to create a custom [StandardTestSuite] subclass. In
+ * particular, if you add 'path/to/mytestsuite' to [TEST_SUITE_DIRECTORIES] in
+ * test.dart, this will all be set up for you.
+ */
+class DirectoryTestSuite extends StandardTestSuite {

[Bill Hesse, 2012/03/28 23:37:30]

I really think we can merge the classes:
Make isTestFile call a closure passed to the constructor.
Default closure for StandardTestSuite is (name)=>name.endsWith("Test.dart");

Then all of DirectoryTestSuite can just be a new constructor for
StandardTestSuite.

This may also allow other subclasses, which only override isTestFile, to be
removed, and to be replaced with instances of StandardTestSuite.

[Bob Nystrom, 2012/03/29 00:10:17]

Excellent idea. Done!

+  factory DirectoryTestSuite(Map configuration, String directory) {
+    final name = directory.substring(directory.lastIndexOf('/') + 1);
+    print(name);

[Bill Hesse, 2012/03/28 23:37:30]

Remove the print statement.

[Bob Nystrom, 2012/03/29 00:10:17]

Done.

+
+    return new DirectoryTestSuite._internal(configuration,
+      name, directory, ['$directory/$name.status']);
+  }
+
+  DirectoryTestSuite._internal(Map configuration,
+                               String suiteName,
+                               String directoryPath,
+                               List<String> statusFilePaths)
+    : super(configuration, suiteName, directoryPath, statusFilePaths);
+
+  bool isTestFile(String filename) => filename.endsWith('_tests.dart');
+}
+
+
 class JUnitTestSuite implements TestSuite {
   Map configuration;
   String suiteName;
   String directoryPath;
   String statusFilePath;
   final String dartDir;
   String buildDir;
   String classPath;
   List<String> testClasses;
   Function doTest;
@@ skipping 293 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
 """;
     print(report);
    }
 }