Properly crash when triggering an ASSERT() in debug DRT.

Properly crash when triggering an ASSERT() in debug DRT.

We would just print the stack trace and keep running.  In webkit_unit_tests,
we would print the stack trace and crash.  Reverse the logic so in
unit_tests, we keep going and in DRT, we crash.

When rolling this into WebKit, we'll need to coordinate with the gardener
since tests will start crashing on the debug bot.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129689

[tony, 2012-03-28 22:26:55]

Dirk noticed this on the bot and I tracked it down.

[tkent, 2012-03-29 00:48:49]

LGTM

[epoger, 2012-03-30 15:32:33]

I'm puzzled, please explain...

1. Don't we ALWAYS want to crash when we encounter an ASSERT in a debug build?
2. In the description, are "webkit_unit_tests" and "unit_tests" meant to refer
to different things or the same thing?
3. Is all of the behavior you refer to in the debug builds, or is some of it in
the release builds?

[tony, 2012-03-30 17:57:26]

On 2012/03/30 15:32:33, epoger wrote:
> I'm puzzled, please explain...
> 
> 1. Don't we ALWAYS want to crash when we encounter an ASSERT in a debug build?

Yes.  That's what this patch does except for when running webkit_unit_tests. 
When running webkit_unit_tests, if we hit an assert, we still want to run the
other unit tests (at least, that seems to be the behavior for other Chromium
unit tests).

> 2. In the description, are "webkit_unit_tests" and "unit_tests" meant to refer
> to different things or the same thing?

Same thing.

> 3. Is all of the behavior you refer to in the debug builds, or is some of it
in
> the release builds?

Debug only.