|
|
Created:
8 years, 9 months ago by Alexei Svitkine (slow) Modified:
8 years, 8 months ago Reviewers:
sky CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src/ Visibility:
Public. |
DescriptionRe-enable use_canvas_skia=1 on Windows.
BUG=105550
TEST=UI text looks the same as before.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129878
Patch Set 1 #
Messages
Total messages: 13 (0 generated)
Hey Scott, I'd like to land this again once I hear confirmation that M19 has been branched off.
LGTM
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/9863053/1
Try job failure for 9863053-1 (retry) on win_rel for steps "ui_tests, browser_tests". It's a second try, previously, steps "ui_tests, browser_tests, installer_util_unittests" failed. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/9863053/1
Try job failure for 9863053-1 (retry) (retry) (retry) on win_rel for step "ui_tests". It's a second try, previously, steps "ui_tests, browser_tests" failed. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/9863053/1
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is win_rel, revision is 129794, job name was 9863053-1 (retry) (retry) (retry) (retry).
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/9863053/1
Try job failure for 9863053-1 (retry) on win_rel for steps "ui_tests, browser_tests". It's a second try, previously, steps "ui_tests, browser_tests" failed. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
On 2012/03/30 16:07:52, I haz the power (commit-bot) wrote: > Try job failure for 9863053-1 (retry) on win_rel for steps "ui_tests, > browser_tests". > It's a second try, previously, steps "ui_tests, browser_tests" failed. > http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu... I reverted this, since it caused similar failures on the main waterfall as it did on the tryservers (e.g. http://build.chromium.org/p/chromium/builders/Win7%20Tests%20%281%29/builds/5533).
On 2012/03/30 18:22:08, Mihai Parparita wrote: > I reverted this, since it caused similar failures on the main waterfall as it > did on the tryservers (e.g. > http://build.chromium.org/p/chromium/builders/Win7%2520Tests%2520%25281%2529/...). Thanks to a tip by rsleevi@, it turned out that these flag changes need a clobber build. When you try to reland this, please coordinate with sheriffs.
Thanks for reverting, sorry for the breakage. On Fri, Mar 30, 2012 at 3:50 PM, <mihaip@chromium.org> wrote: > On 2012/03/30 18:22:08, Mihai Parparita wrote: >> >> I reverted this, since it caused similar failures on the main waterfall as >> it >> did on the tryservers (e.g. > > > http://build.chromium.org/p/chromium/builders/Win7%2520Tests%2520%25281%2529/...). > > Thanks to a tip by rsleevi@, it turned out that these flag changes need a > clobber build. When you try to reland this, please coordinate with sheriffs. > > https://chromiumcodereview.appspot.com/9863053/ |