Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 9863053: Re-enable use_canvas_skia=1 on Windows. (Closed)

Created:
8 years, 9 months ago by Alexei Svitkine (slow)
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Re-enable use_canvas_skia=1 on Windows. BUG=105550 TEST=UI text looks the same as before. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Alexei Svitkine (slow)
Hey Scott, I'd like to land this again once I hear confirmation that M19 has ...
8 years, 9 months ago (2012-03-27 20:55:49 UTC) #1
sky
LGTM
8 years, 9 months ago (2012-03-27 21:01:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/9863053/1
8 years, 8 months ago (2012-03-29 13:39:09 UTC) #3
commit-bot: I haz the power
Try job failure for 9863053-1 (retry) on win_rel for steps "ui_tests, browser_tests". It's a second ...
8 years, 8 months ago (2012-03-29 16:47:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/9863053/1
8 years, 8 months ago (2012-03-29 16:49:06 UTC) #5
commit-bot: I haz the power
Try job failure for 9863053-1 (retry) (retry) (retry) on win_rel for step "ui_tests". It's a ...
8 years, 8 months ago (2012-03-29 23:07:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/9863053/1
8 years, 8 months ago (2012-03-30 00:32:34 UTC) #7
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 8 months ago (2012-03-30 06:10:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/9863053/1
8 years, 8 months ago (2012-03-30 13:04:07 UTC) #9
commit-bot: I haz the power
Try job failure for 9863053-1 (retry) on win_rel for steps "ui_tests, browser_tests". It's a second ...
8 years, 8 months ago (2012-03-30 16:07:52 UTC) #10
Mihai Parparita -not on Chrome
On 2012/03/30 16:07:52, I haz the power (commit-bot) wrote: > Try job failure for 9863053-1 ...
8 years, 8 months ago (2012-03-30 18:22:08 UTC) #11
Mihai Parparita -not on Chrome
On 2012/03/30 18:22:08, Mihai Parparita wrote: > I reverted this, since it caused similar failures ...
8 years, 8 months ago (2012-03-30 19:50:26 UTC) #12
Alexei Svitkine (slow)
8 years, 8 months ago (2012-03-30 21:41:38 UTC) #13
Thanks for reverting, sorry for the breakage.

On Fri, Mar 30, 2012 at 3:50 PM,  <mihaip@chromium.org> wrote:
> On 2012/03/30 18:22:08, Mihai Parparita wrote:
>>
>> I reverted this, since it caused similar failures on the main waterfall as
>> it
>> did on the tryservers  (e.g.
>
>
>
http://build.chromium.org/p/chromium/builders/Win7%2520Tests%2520%25281%2529/...).
>
> Thanks to a tip by rsleevi@, it turned out that these flag changes need a
> clobber build. When you try to reland this, please coordinate with sheriffs.
>
> https://chromiumcodereview.appspot.com/9863053/

Powered by Google App Engine
This is Rietveld 408576698