frog/leg/typechecker.dart - Issue 9863037: Generate prettier loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/leg/typechecker.dart

Issue 9863037: Generate prettier loops. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: frog/leg/typechecker.dart

diff --git a/frog/leg/typechecker.dart b/frog/leg/typechecker.dart

index ef555b2a420e88e1cba9224a75c35fbeffce3301..11ba1ee98ed0a6b5b955afa72898735a494c67ed 100644

--- a/frog/leg/typechecker.dart

+++ b/frog/leg/typechecker.dart

@@ -668,7 +668,7 @@ class TypeCheckerVisitor implements Visitor<Type> {

return StatementType.NOT_RETURNING;

}

- visitForInStatement(ForInStatement node) {

+ visitForIn(ForIn node) {

analyze(node.expression);

StatementType bodyType = analyze(node.body);

return bodyType.join(StatementType.NOT_RETURNING);

« no previous file with comments | « frog/leg/tree/visitors.dart ('k') | frog/tests/leg/src/LoopTest.dart » ('j') | no next file with comments »