[Sync] [Mac] Implement one-click signin bubble for OS X

[Sync] [Mac] Implement one-click signin bubble for OS X

Add new class OneClickSigninBubbleController.

Factor out logic from views implementation of one-click bubble so that
both it and OneClickSigninBubbleController can behave similarly.

BUG=117899, 116685
TEST=On OSX, with a clean profile, sign into GMail.  The one-click infobar should pop up, clicking "OK, sync" should bring up the one-click dialog, and confirming should bring up the bubble by the wrench menu.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129421

[akalin, 2012-03-27 11:24:36]

+rsesek for cocoa stuff
+rogerta for everything else

(screenshot on http://code.google.com/p/chromium/issues/detail?id=117899 )

[akalin, 2012-03-27 11:27:38]

On 2012/03/27 11:24:36, akalin wrote:
> +rsesek for cocoa stuff
> +rogerta for everything else
> 
> (screenshot on http://code.google.com/p/chromium/issues/detail?id=117899 )

rsesek@, once you LGTM this patch, I'll need you to resave the .xib in 10.6
again.

[Roger Tawa OOO till Jul 10th, 2012-03-27 16:41:43]

lgtm for non-mac code.

[Robert Sesek, 2012-03-27 19:25:07]

Code LGTM, but based on the screen shot, you need to do some small tweaks: The
left edges of the links should be aligned with the text body. And the text
baseline of the link should be aligned with that of the OK button. Also, you
should change the button size to be NSControlSizeSmall so that its visual weight
matches the text.

There also seems to be a bit too much padding around the edges of the bubble and
between the Learn More and Advanced links (which may be fixed when you change
the button size).

[akalin, 2012-03-27 23:42:23]

On 2012/03/27 19:25:07, rsesek wrote:
> Code LGTM, but based on the screen shot, you need to do some small tweaks: The
> left edges of the links should be aligned with the text body. And the text
> baseline of the link should be aligned with that of the OK button. Also, you
> should change the button size to be NSControlSizeSmall so that its visual
weight
> matches the text.
> 
> There also seems to be a bit too much padding around the edges of the bubble
and
> between the Learn More and Advanced links (which may be fixed when you change
> the button size).

Okay fixed nib and uploaded new screenshot in bug.  PTAL.

[Robert Sesek, 2012-03-27 23:48:14]

LGTM

[akalin, 2012-03-28 00:29:25]

OWNERS:
+estade for gtk
+jianli for panels
+sky for root ui

I may end up TBRing one or more of you.

[sky, 2012-03-28 14:49:17]

LGTM

http://codereview.chromium.org/9863032/diff/7006/chrome/browser/ui/views/sync...
File chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc (right):

http://codereview.chromium.org/9863032/diff/7006/chrome/browser/ui/views/sync...
chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc:171: if (source ==
learn_more_link_) {
nit: no {}

http://codereview.chromium.org/9863032/diff/7006/chrome/browser/ui/views/sync...
File chrome/browser/ui/views/sync/one_click_signin_bubble_view_browsertest.cc
(right):

http://codereview.chromium.org/9863032/diff/7006/chrome/browser/ui/views/sync...
chrome/browser/ui/views/sync/one_click_signin_bubble_view_browsertest.cc:8:
#include "chrome/browser/ui/views/sync/one_click_signin_bubble_view.h"
nit: this should be the first include.

[akalin, 2012-03-28 15:19:20]

Committing soonish

http://codereview.chromium.org/9863032/diff/7006/chrome/browser/ui/views/sync...
File chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc (right):

http://codereview.chromium.org/9863032/diff/7006/chrome/browser/ui/views/sync...
chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc:171: if (source ==
learn_more_link_) {
On 2012/03/28 14:49:17, sky wrote:
> nit: no {}

Done.

http://codereview.chromium.org/9863032/diff/7006/chrome/browser/ui/views/sync...
File chrome/browser/ui/views/sync/one_click_signin_bubble_view_browsertest.cc
(right):

http://codereview.chromium.org/9863032/diff/7006/chrome/browser/ui/views/sync...
chrome/browser/ui/views/sync/one_click_signin_bubble_view_browsertest.cc:8:
#include "chrome/browser/ui/views/sync/one_click_signin_bubble_view.h"
On 2012/03/28 14:49:17, sky wrote:
> nit: this should be the first include.

Done.

[commit-bot: I haz the power, 2012-03-28 15:19:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/9863032/14002