Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: tests/standalone/src/io/ProcessInvalidArgumentsTest.dart

Issue 9863015: This is a request for comments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/src/io/ProcessExitTest.dart ('k') | tests/standalone/src/io/ProcessRunOutput.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/src/io/ProcessInvalidArgumentsTest.dart
diff --git a/tests/standalone/src/io/ProcessInvalidArgumentsTest.dart b/tests/standalone/src/io/ProcessInvalidArgumentsTest.dart
index 94ecda5ebb4c08644fec6f7bb34a5ca040ad29ec..ad44d461b1adc1871072f4db6f497c828ec8d1ee 100644
--- a/tests/standalone/src/io/ProcessInvalidArgumentsTest.dart
+++ b/tests/standalone/src/io/ProcessInvalidArgumentsTest.dart
@@ -1,4 +1,4 @@
-// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
//
@@ -8,9 +8,35 @@
void main() {
Expect.throws(() => new Process.start(["true"], []),
- (e) => e is ProcessException);
+ (e) => e is IllegalArgumentException);
Expect.throws(() => new Process.start("true", "asdf"),
- (e) => e is ProcessException);
+ (e) => e is IllegalArgumentException);
Expect.throws(() => new Process.start("true", ["asdf", 1]),
- (e) => e is ProcessException);
+ (e) => e is IllegalArgumentException);
+ Expect.throws(() => new Process.run(["true"], [], null,
+ (exit, out, err) => null),
+ (e) => e is IllegalArgumentException);
+ Expect.throws(() => new Process.run("true", "asdf", null,
+ (exit, out, err) => null),
+ (e) => e is IllegalArgumentException);
+ Expect.throws(() => new Process.run("true", ["asdf", 1], null,
+ (exit, out, err) => null),
+ (e) => e is IllegalArgumentException);
+ var options = new ProcessOptions();
+ options.workingDirectory = 23;
+ Expect.throws(() => new Process.start("true", [], options),
+ (e) => e is IllegalArgumentException);
+ Expect.throws(() => new Process.run("true", [], options,
+ (exit, out, err) => null),
+ (e) => e is IllegalArgumentException);
+ options = new ProcessOptions();
+ options.stdoutEncoding = 23;
+ Expect.throws(() => new Process.run("true", [], options,
+ (exit, out, err) => null),
+ (e) => e is IllegalArgumentException);
+ options = new ProcessOptions();
+ options.stderrEncoding = 23;
+ Expect.throws(() => new Process.run("true", [], options,
+ (exit, out, err) => null),
+ (e) => e is IllegalArgumentException);
}
« no previous file with comments | « tests/standalone/src/io/ProcessExitTest.dart ('k') | tests/standalone/src/io/ProcessRunOutput.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698