Modify enuminsts to be able to communicate matched instructions accross

Modify enuminsts to be able to communicate matched instructions accross
a pipe.
Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8130

[Brad Chen, 2012-03-28 17:26:43]

https://chromiumcodereview.appspot.com/9861030/diff/1/src/trusted/validator/x...
File src/trusted/validator/x86/testing/enuminsts/input_tester.c (right):

https://chromiumcodereview.appspot.com/9861030/diff/1/src/trusted/validator/x...
src/trusted/validator/x86/testing/enuminsts/input_tester.c:57: static void
ParseInst(NaClEnumerator* enumerator, int pc_address) {
const int pc_address?

What is the enumerator for? It looks like it's getting passed all over the place
in this file but nobody is using it.

https://chromiumcodereview.appspot.com/9861030/diff/1/src/trusted/validator/x...
src/trusted/validator/x86/testing/enuminsts/input_tester.c:66: static void
AssembleDesc(NaClEnumerator* enumerator) {
Please make these parameters const if they are not written.

https://chromiumcodereview.appspot.com/9861030/diff/1/src/trusted/validator/x...
src/trusted/validator/x86/testing/enuminsts/input_tester.c:180: int
ReadAnInstruction(uint8_t ibytes[NACL_ENUM_MAX_INSTRUCTION_BYTES]) {
Would a typedef for this array make this code cleaner?

https://chromiumcodereview.appspot.com/9861030/diff/1/src/trusted/validator/x...
File src/trusted/validator/x86/testing/enuminsts/text2hex.h (right):

https://chromiumcodereview.appspot.com/9861030/diff/1/src/trusted/validator/x...
src/trusted/validator/x86/testing/enuminsts/text2hex.h:8: * text2bytes.h
Doesn't match filename. Maybe simpler just to omit the filename from the
comment.

https://chromiumcodereview.appspot.com/9861030/diff/1/src/trusted/validator/x...
src/trusted/validator/x86/testing/enuminsts/text2hex.h:30: char* itext,
const?

[Karl, 2012-03-28 18:25:28]

Updated as requested.

https://chromiumcodereview.appspot.com/9861030/diff/1/src/trusted/validator/x...
File src/trusted/validator/x86/testing/enuminsts/input_tester.c (right):

https://chromiumcodereview.appspot.com/9861030/diff/1/src/trusted/validator/x...
src/trusted/validator/x86/testing/enuminsts/input_tester.c:57: static void
ParseInst(NaClEnumerator* enumerator, int pc_address) {
On 2012/03/28 17:26:43, Brad Chen wrote:
> const int pc_address?
> 
> What is the enumerator for? It looks like it's getting passed all over the
place
> in this file but nobody is using it.

It is there because of the API expected by callers. The enumerator construct has
data (i.e. the text to parse) that is used by other decoders. Only this decoder,
which circumvents this (because it is acting as a surrogate for a decoder in a
different process). That is why you don't see it being used in this file.

https://chromiumcodereview.appspot.com/9861030/diff/1/src/trusted/validator/x...
src/trusted/validator/x86/testing/enuminsts/input_tester.c:66: static void
AssembleDesc(NaClEnumerator* enumerator) {
On 2012/03/28 17:26:43, Brad Chen wrote:
> Please make these parameters const if they are not written.

At one time, API functions updated the enumerator. However, since this is no
longer true, I'll change the API to assume all parameters are constants.

https://chromiumcodereview.appspot.com/9861030/diff/1/src/trusted/validator/x...
src/trusted/validator/x86/testing/enuminsts/input_tester.c:180: int
ReadAnInstruction(uint8_t ibytes[NACL_ENUM_MAX_INSTRUCTION_BYTES]) {
On 2012/03/28 17:26:43, Brad Chen wrote:
> Would a typedef for this array make this code cleaner?

Done.

https://chromiumcodereview.appspot.com/9861030/diff/1/src/trusted/validator/x...
File src/trusted/validator/x86/testing/enuminsts/text2hex.h (right):

https://chromiumcodereview.appspot.com/9861030/diff/1/src/trusted/validator/x...
src/trusted/validator/x86/testing/enuminsts/text2hex.h:30: char* itext,
On 2012/03/28 17:26:43, Brad Chen wrote:
> const?

Done.

[Brad Chen, 2012-03-28 19:50:20]

LGTM