Speech refactoring: Turned AudioChunk into a refcounted class (CL1.4)

content/browser/speech/google_one_shot_remote_engine_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "content/browser/speech/audio_buffer.h"
 #include "content/browser/speech/google_one_shot_remote_engine.h"
 #include "content/public/common/speech_recognition_error.h"
 #include "content/public/common/speech_recognition_result.h"
@@ skipping 30 matching lines @@
   MessageLoop message_loop_;
   TestURLFetcherFactory url_fetcher_factory_;
   content::SpeechRecognitionErrorCode error_;
   content::SpeechRecognitionResult result_;
 };
 
 void GoogleOneShotRemoteEngineTest::CreateAndTestRequest(
     bool success, const std::string& http_response) {
   GoogleOneShotRemoteEngine client(NULL);
   unsigned char dummy_audio_buffer_data[2] = {'\0', '\0'};
-  AudioChunk dummy_audio_chunk(&dummy_audio_buffer_data[0],
-                               sizeof(dummy_audio_buffer_data),
-                               2 /* bytes per sample */);
+  scoped_refptr<AudioChunk> dummy_audio_chunk(
+      new AudioChunk(&dummy_audio_buffer_data[0],
+                     sizeof(dummy_audio_buffer_data),
+                     2 /* bytes per sample */));
   client.set_delegate(this);
   client.StartRecognition();
-  client.TakeAudioChunk(dummy_audio_chunk);
+  client.TakeAudioChunk(*dummy_audio_chunk);

[hans, 2012/03/27 15:56:31]

hmm, i'm trying to think whether passing the AudioChunk by constref to
TakeAudioChunk still makes sense..

[Primiano Tucci (use gerrit), 2012/03/27 16:51:24]

I kept the const ref for all those methods that don't use/keep the chunk after
returning from the call. After all, if they just use it synchronously, they
don't need to know any detail about the memory ownership of that audio chunk.

   client.AudioChunksEnded();
   TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0);
   ASSERT_TRUE(fetcher);
 
   fetcher->set_url(fetcher->GetOriginalURL());
   net::URLRequestStatus status;
   status.set_status(success ? net::URLRequestStatus::SUCCESS :
                               net::URLRequestStatus::FAILED);
   fetcher->set_status(status);
   fetcher->set_response_code(success ? 200 : 500);
@@ skipping 46 matching lines @@
   EXPECT_EQ(0U, result_.hypotheses.size());
 
   // Malformed JSON case.
   CreateAndTestRequest(true, "{\"status\":0,\"hypotheses\":"
       "[{\"unknownkey\":\"hello\"}]}");
   EXPECT_EQ(error_, content::SPEECH_RECOGNITION_ERROR_NETWORK);
   EXPECT_EQ(0U, result_.hypotheses.size());
 }
 
 }  // namespace speech