[NTP4] Fix theme and bookmarks bar notifications.

[NTP4] Fix theme and bookmarks bar notifications.

R=estade@chromium.org
BUG=117027
TEST=Change theme with incognito browser open.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129301

[Dan Beam, 2012-03-27 10:30:12]

https://chromiumcodereview.appspot.com/9861016/diff/1/chrome/browser/resource...
File chrome/browser/resources/incognito_tab.html (right):

https://chromiumcodereview.appspot.com/9861016/diff/1/chrome/browser/resource...
chrome/browser/resources/incognito_tab.html:23: <script
src="chrome://resources/js/cr.js"></script>
I don't really have to do this, but I figured it wasn't too expensive: I can
change to vanilla namespace as well if you don't want to depend on cr.js here.

https://chromiumcodereview.appspot.com/9861016/diff/1/chrome/browser/resource...
File chrome/browser/resources/new_incognito_tab_theme.css (right):

https://chromiumcodereview.appspot.com/9861016/diff/1/chrome/browser/resource...
chrome/browser/resources/new_incognito_tab_theme.css:8: background-color: $2;
figured I'd fix style nits while around...

https://chromiumcodereview.appspot.com/9861016/diff/1/chrome/browser/ui/webui...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

https://chromiumcodereview.appspot.com/9861016/diff/1/chrome/browser/ui/webui...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:208: return is_incognito ?
new_tab_incognito_html_.get() :
tell me if this is not right thing to do or if you prefer I didn't (just noticed
while I was in code)

[Evan Stade, 2012-03-27 18:25:09]

lgtm

http://codereview.chromium.org/9861016/diff/1/chrome/browser/resources/incogn...
File chrome/browser/resources/incognito_tab.html (right):

http://codereview.chromium.org/9861016/diff/1/chrome/browser/resources/incogn...
chrome/browser/resources/incognito_tab.html:23: <script
src="chrome://resources/js/cr.js"></script>
On 2012/03/27 10:30:13, Dan Beam wrote:
> I don't really have to do this, but I figured it wasn't too expensive: I can
> change to vanilla namespace as well if you don't want to depend on cr.js here.

it's fine

[commit-bot: I haz the power, 2012-03-27 19:01:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/9861016/1

[commit-bot: I haz the power, 2012-03-27 20:22:34]

Try job failure for 9861016-1 (retry) on win for step "compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...