Coverity: check null returns.

Coverity: check null returns.

CID=102833, 102995
BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129477

[kmadhusu, 2012-03-27 18:01:00]

Please review the null check returns.

net_internals_ui.cc
simonjam@chromium.org

configuraation_policy_handler.cc
joaodasilva@chromium.org

Thanks.

[eroman, 2012-03-27 18:05:52]

https://chromiumcodereview.appspot.com/9860044/diff/1/chrome/browser/ui/webui...
File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):

https://chromiumcodereview.appspot.com/9860044/diff/1/chrome/browser/ui/webui...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:1272: Value*
pipelined_conneciton_info = NULL;
nit: can you fix the typo on connection_info?

https://chromiumcodereview.appspot.com/9860044/diff/1/chrome/browser/ui/webui...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:1274:
http_network_session->http_stream_factory()->PipelineInfoToValue();
Need to assign to pipelined_connection_info or this has no effect!

[kmadhusu, 2012-03-27 18:19:03]

eroman@: Addressed review comments.

Thanks.

https://chromiumcodereview.appspot.com/9860044/diff/1/chrome/browser/ui/webui...
File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):

https://chromiumcodereview.appspot.com/9860044/diff/1/chrome/browser/ui/webui...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:1272: Value*
pipelined_conneciton_info = NULL;
On 2012/03/27 18:05:52, eroman wrote:
> nit: can you fix the typo on connection_info?

Done.

https://chromiumcodereview.appspot.com/9860044/diff/1/chrome/browser/ui/webui...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:1274:
http_network_session->http_stream_factory()->PipelineInfoToValue();
On 2012/03/27 18:05:52, eroman wrote:
> Need to assign to pipelined_connection_info or this has no effect!

oops. Forgot to assign it. Fixed.

[eroman, 2012-03-27 18:24:12]

lgtm for net_internals_ui.cc

[James Simonsen, 2012-03-27 18:24:21]

lgtm

[commit-bot: I haz the power, 2012-03-27 18:36:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/9860044/3001

[commit-bot: I haz the power, 2012-03-27 18:36:39]

Presubmit check for 9860044-3001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/policy

Presubmit checks took 1.2s to calculate.

[kmadhusu, 2012-03-27 20:34:42]

Joao da Silva: OWNERS check failed. Can you lgtm?

[Joao da Silva, 2012-03-28 08:19:53]

lgtm

[commit-bot: I haz the power, 2012-03-28 08:20:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/9860044/3001

[commit-bot: I haz the power, 2012-03-28 08:29:00]

Try job failure for 9860044-3001 on linux_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-03-28 08:32:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/9860044/3001

[commit-bot: I haz the power, 2012-03-28 08:38:57]

Try job failure for 9860044-3001 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-03-28 12:30:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/9860044/3001

[commit-bot: I haz the power, 2012-03-28 15:24:50]

Try job failure for 9860044-3001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, steps "ui_tests, browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-28 16:32:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/9860044/3001

[commit-bot: I haz the power, 2012-03-28 20:19:48]

Change committed as 129477