Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Unified Diff: media/tools/player_x11/player_x11.cc

Issue 9860027: Remove DemuxerFactory and URL parameter from Pipeline. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: added some todos Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/tools/player_x11/player_x11.cc
diff --git a/media/tools/player_x11/player_x11.cc b/media/tools/player_x11/player_x11.cc
index 8da75deb65f835f471350ff15a65083d77f57c38..f7618ba2af58e5a6536f0f78385130fca220f957 100644
--- a/media/tools/player_x11/player_x11.cc
+++ b/media/tools/player_x11/player_x11.cc
@@ -24,7 +24,7 @@
#include "media/base/pipeline.h"
#include "media/base/video_frame.h"
#include "media/filters/ffmpeg_audio_decoder.h"
-#include "media/filters/ffmpeg_demuxer_factory.h"
+#include "media/filters/ffmpeg_demuxer.h"
#include "media/filters/ffmpeg_video_decoder.h"
#include "media/filters/file_data_source.h"
#include "media/filters/null_audio_renderer.h"
@@ -121,8 +121,8 @@ bool InitPipeline(MessageLoop* message_loop,
// Create our filter factories.
scoped_ptr<media::FilterCollection> collection(
new media::FilterCollection());
- collection->SetDemuxerFactory(scoped_ptr<media::DemuxerFactory>(
- new media::FFmpegDemuxerFactory(data_source, message_loop)));
+ collection->SetDemuxer(new media::FFmpegDemuxer(
+ message_loop, data_source, true));
collection->AddAudioDecoder(new media::FFmpegAudioDecoder(
base::Bind(&media::MessageLoopFactory::GetMessageLoop,
base::Unretained(message_loop_factory),
@@ -145,7 +145,7 @@ bool InitPipeline(MessageLoop* message_loop,
*pipeline = new media::Pipeline(message_loop, new media::MediaLog());
media::PipelineStatusNotification note;
(*pipeline)->Start(
- collection.Pass(), "", media::PipelineStatusCB(),
+ collection.Pass(), media::PipelineStatusCB(),
media::PipelineStatusCB(), media::NetworkEventCB(),
note.Callback());

Powered by Google App Engine
This is Rietveld 408576698