Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: media/filters/pipeline_integration_test_base.cc

Issue 9860027: Remove DemuxerFactory and URL parameter from Pipeline. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: added some todos Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/pipeline_integration_test_base.cc
diff --git a/media/filters/pipeline_integration_test_base.cc b/media/filters/pipeline_integration_test_base.cc
index 91ca357ac14ffa8852e71aed1b7e98bde6c9e37b..ecd8315467afa5500de95e5ef3ac5f113ae51a67 100644
--- a/media/filters/pipeline_integration_test_base.cc
+++ b/media/filters/pipeline_integration_test_base.cc
@@ -6,9 +6,9 @@
#include "base/bind.h"
#include "media/base/media_log.h"
-#include "media/filters/chunk_demuxer_factory.h"
+#include "media/filters/chunk_demuxer.h"
#include "media/filters/ffmpeg_audio_decoder.h"
-#include "media/filters/ffmpeg_demuxer_factory.h"
+#include "media/filters/ffmpeg_demuxer.h"
#include "media/filters/ffmpeg_video_decoder.h"
#include "media/filters/file_data_source.h"
#include "media/filters/null_audio_renderer.h"
@@ -81,7 +81,6 @@ bool PipelineIntegrationTestBase::Start(const std::string& url,
PipelineStatus expected_status) {
pipeline_->Start(
CreateFilterCollection(url),
- url,
base::Bind(&PipelineIntegrationTestBase::OnEnded, base::Unretained(this)),
base::Bind(&PipelineIntegrationTestBase::OnError, base::Unretained(this)),
NetworkEventCB(),
@@ -147,22 +146,21 @@ scoped_ptr<FilterCollection>
PipelineIntegrationTestBase::CreateFilterCollection(const std::string& url) {
scoped_refptr<FileDataSource> data_source = new FileDataSource();
CHECK_EQ(PIPELINE_OK, data_source->Initialize(url));
- return CreateFilterCollection(scoped_ptr<DemuxerFactory>(
- new FFmpegDemuxerFactory(data_source, &message_loop_)));
+ return CreateFilterCollection(new FFmpegDemuxer(
+ &message_loop_, data_source, false));
}
scoped_ptr<FilterCollection>
PipelineIntegrationTestBase::CreateFilterCollection(
ChunkDemuxerClient* client) {
- return CreateFilterCollection(scoped_ptr<DemuxerFactory>(
- new ChunkDemuxerFactory(client)));
+ return CreateFilterCollection(new ChunkDemuxer(client));
}
scoped_ptr<FilterCollection>
PipelineIntegrationTestBase::CreateFilterCollection(
- scoped_ptr<DemuxerFactory> demuxer_factory) {
+ const scoped_refptr<Demuxer>& demuxer) {
scoped_ptr<FilterCollection> collection(new FilterCollection());
- collection->SetDemuxerFactory(demuxer_factory.Pass());
+ collection->SetDemuxer(demuxer);
collection->AddAudioDecoder(new FFmpegAudioDecoder(
base::Bind(&MessageLoopFactory::GetMessageLoop,
base::Unretained(message_loop_factory_.get()),

Powered by Google App Engine
This is Rietveld 408576698