Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9860009: Removes dartc reliance on its own libraries, now can be targeted at any implementation's libraries (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated 'configs' to be 'config' directory, updated addLib() to throw exception Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 4bbd4f41e68941e3fa7c5691e16e3c0937fc745e..fdd5247a16afcdb2189cd8114e586c60d4967d76 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -995,12 +995,11 @@ class JUnitTestSuite implements TestSuite {
}
void createTest(successIgnored) {
- String d8 =
- "$buildDir/d8${TestUtils.executableSuffix(configuration['component'])}";
+ var sdkDir = "$buildDir/dart-sdk".trim();
List<String> args = <String>[
'-ea',
'-classpath', classPath,
- '-Dcom.google.dart.runner.d8=$d8',
+ '-Dcom.google.dart.sdk=$sdkDir',
'-Dcom.google.dart.corelib.SharedTests.test_py=' +
dartDir + '/tools/test.py',
'org.junit.runner.JUnitCore'];
@@ -1020,13 +1019,11 @@ class JUnitTestSuite implements TestSuite {
void computeClassPath() {
classPath = Strings.join(
['$buildDir/compiler/lib/dartc.jar',
- '$buildDir/compiler/lib/corelib.jar',
'$buildDir/compiler-tests.jar',
'$buildDir/closure_out/compiler.jar',
// Third party libraries.
'$dartDir/third_party/args4j/2.0.12/args4j-2.0.12.jar',
'$dartDir/third_party/guava/r09/guava-r09.jar',
- '$dartDir/third_party/json/r2_20080312/json.jar',
'$dartDir/third_party/rhino/1_7R3/js.jar',
'$dartDir/third_party/hamcrest/v1_3/hamcrest-core-1.3.0RC2.jar',
'$dartDir/third_party/hamcrest/v1_3/hamcrest-generator-1.3.0RC2.jar',

Powered by Google App Engine
This is Rietveld 408576698