Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 9860005: Disables ctrl-shift-q on login screen (Closed)

Created:
8 years, 9 months ago by pkotwicz
Modified:
8 years, 9 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, mazda+watch_chromium.org, sadrul, derat+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Disables ctrl-shift-q on login screen BUG=105964 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129132

Patch Set 1 #

Patch Set 2 : Nicer diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ash/accelerators/accelerator_table.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
pkotwicz
8 years, 9 months ago (2012-03-26 22:13:59 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 9 months ago (2012-03-26 22:17:50 UTC) #2
Daniel Erat
description nit: You mean Ctrl-Shift-Q rather than Ctrl-Alt-Q, right? Ctrl-Alt-Q shouldn't be doing anything anywhere.
8 years, 9 months ago (2012-03-26 22:26:01 UTC) #3
pkotwicz
That's correct. I should update the bug.
8 years, 9 months ago (2012-03-26 22:56:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/9860005/1002
8 years, 9 months ago (2012-03-26 23:06:00 UTC) #5
commit-bot: I haz the power
Try job failure for 9860005-1002 (retry) (previous was lost) on win_rel for step "browser_tests". It's ...
8 years, 9 months ago (2012-03-27 02:36:00 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-27 02:57:48 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698